Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1441)

Issue 6774051: Further refinements to charm config panel.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by bac
Modified:
11 years, 6 months ago
Reviewers:
mp+131581
Visibility:
Public.

Description

Further refinements to charm config panel. * Change config file input widget from native HTML5 widget to an image overlay. * Replace deploy and cancel buttons with CSS. They don't exactly match the visual design but that will come in the next branch. * Set charm panel background. There is a problem in that it doesn't go to the bottom but Gary's branch will fix it. https://code.launchpad.net/~bac/juju-gui/charm-assets-deux/+merge/131581 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Further refinements to charm config panel. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -38 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/getfile_button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/getfile_button-pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/templates/charm-pre-configuration.handlebars View 1 chunk +8 lines, -3 lines 0 comments Download
M app/views/charm-search.js View 1 4 chunks +22 lines, -12 lines 0 comments Download
M lib/views/stylesheet.less View 1 7 chunks +54 lines, -13 lines 0 comments Download
M test/test_charm_configuration.js View 1 4 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
11 years, 6 months ago (2012-10-26 10:48:48 UTC) #1
gary.poster
Thanks Brad. This is a nice improvement. As I mentioned, I merged with my branch ...
11 years, 6 months ago (2012-10-28 18:34:37 UTC) #2
bac
11 years, 6 months ago (2012-10-29 09:33:16 UTC) #3
*** Submitted:

Further refinements to charm config panel.

* Change config file input widget from native HTML5 widget to an image
  overlay.

* Replace deploy and cancel buttons with CSS.  They don't exactly
  match the visual design but that will come in the next branch.

* Set charm panel background.  There is a problem in that it doesn't
  go to the bottom but Gary's branch will fix it.

R=
CC=
https://codereview.appspot.com/6774051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b