Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(188)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6774045: [api 1.12] Subscription.getSubscriptionExpires and getTopicID, JavaDoc improvements, & subscription… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by yanivi
Modified:
14 years ago
Reviewers:
ngmiceli
CC:
rmistry
Base URL:
https://google-api-java-client.googlecode.com/hg/
Visibility:
Public.

Description

Add Subscription.getSubscriptionExpires and getTopicID JavaDoc improvements to Subscriptions and Android Auth Move EVENT_TYPE_HEADER and UNSUBSCRIBE_HEADER our of SubscriptionHeaders and into Notification and AbstractWebHookServlet respectively

Patch Set 1 #

Patch Set 2 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -171 lines) Patch
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GooglePlayServicesAvailabilityIOException.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/UserRecoverableAuthIOException.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-appengine/src/test/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStoreTest.java View 6 chunks +20 lines, -13 lines 0 comments Download
M google-api-client-appengine/src/test/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStoreTest.java View 5 chunks +16 lines, -9 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/AbstractWebHookServlet.java View 4 chunks +9 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java View 1 chunk +1 line, -3 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Notification.java View 1 chunk +6 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Subscription.java View 2 chunks +52 lines, -42 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionHeaders.java View 2 chunks +77 lines, -88 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/subscriptions/JsonNotificationCallbackTest.java View 3 chunks +7 lines, -5 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/subscriptions/MemorySubscriptionStoreTest.java View 3 chunks +8 lines, -4 lines 0 comments Download
A google-api-client/src/test/java/com/google/api/client/googleapis/subscriptions/SubscriptionHeadersTest.java View 1 chunk +49 lines, -0 lines 0 comments Download
A google-api-client/src/test/java/com/google/api/client/googleapis/subscriptions/SubscriptionTest.java View 1 chunk +48 lines, -0 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/subscriptions/UnparsedNotificationTest.java View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2
yanivi
14 years ago (2012-10-25 19:32:21 UTC) #1
ngmiceli
14 years ago (2012-10-25 20:17:26 UTC) #2 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b