code review 67730048: runtime: use monotonic clock for timers on linux/arm

runtime: use monotonic clock for timers on linux/arm

Update issue 6007

[mikio, 2014-02-24 17:37:43]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2014-02-25 00:43:45]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[dvyukov, 2014-02-25 03:40:41]

LGTM after fixing the comment

https://codereview.appspot.com/67730048/diff/60001/src/pkg/runtime/sys_linux_...
File src/pkg/runtime/sys_linux_arm.s (right):

https://codereview.appspot.com/67730048/diff/60001/src/pkg/runtime/sys_linux_...
src/pkg/runtime/sys_linux_arm.s:161: MOVW	$1, R0  // CLOCK_MONOTONIC
this must be REALTIME
time.Now() still returns real time

[mikio, 2014-02-25 03:57:01]

On Tue, Feb 25, 2014 at 12:40 PM,  <dvyukov@google.com> wrote:

> src/pkg/runtime/sys_linux_arm.s:161: MOVW       $1, R0  // CLOCK_MONOTONIC
> this must be REALTIME
> time.Now() still returns real time

ah, thx. that means the line should be "MOVW $0,R0 // CLOCK_REALTIME" ?

[dvyukov, 2014-02-25 06:08:55]

On Tue, Feb 25, 2014 at 7:57 AM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> On Tue, Feb 25, 2014 at 12:40 PM,  <dvyukov@google.com> wrote:
>
>> src/pkg/runtime/sys_linux_arm.s:161: MOVW       $1, R0  // CLOCK_MONOTONIC
>> this must be REALTIME
>> time.Now() still returns real time
>
> ah, thx. that means the line should be "MOVW $0,R0 // CLOCK_REALTIME" ?

just revert that line
and then LGTM

[mikio, 2014-02-25 06:33:38]

thanks, will submit later.

On Tue, Feb 25, 2014 at 3:08 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> On Tue, Feb 25, 2014 at 7:57 AM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
>> On Tue, Feb 25, 2014 at 12:40 PM,  <dvyukov@google.com> wrote:
>>
>>> src/pkg/runtime/sys_linux_arm.s:161: MOVW       $1, R0  // CLOCK_MONOTONIC
>>> this must be REALTIME
>>> time.Now() still returns real time
>>
>> ah, thx. that means the line should be "MOVW $0,R0 // CLOCK_REALTIME" ?
>
> just revert that line
> and then LGTM

[mikio, 2014-02-25 14:03:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=6d788e8e2b63 ***

runtime: use monotonic clock for timers on linux/arm

Update issue 6007

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/67730048

[gobot, 2014-02-25 14:16:25]

This CL appears to have broken the freebsd-amd64 builder.