Issue 6766052: Render menus more intelligently

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6766052: Render menus more intelligently

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by matthew.scott

Modified:
11 years, 6 months ago

Reviewers:
mp+131384

Visibility:
Public.

Description

Render menus more intelligently Menus are rendered to the right or left of the service node depending on which side of the environment view they are on, and the menus track better with scrolling (around the arrow rather than around the top of the menu). https://code.launchpad.net/~makyo/juju-gui/menu-positioning/+merge/131384 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Render menus more intelligently #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -3 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/icons/icon_shadow_triangle_right.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/views/environment.js	View	1	2 chunks	+26 lines, -2 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, nice feature. https://codereview.appspot.com/6766052/diff/1/app/views/environment.js File app/views/environment.js (left): https://codereview.appspot.com/6766052/diff/1/app/views/environment.js#oldcode1300 app/views/environment.js:1300: if (service) { Your other branch ...

11 years, 6 months ago (2012-10-25 16:02:48 UTC) #2

matthew.scott

11 years, 6 months ago (2012-10-26 06:36:47 UTC) #3

*** Submitted:

Render menus more intelligently

Menus are rendered to the right or left of the service node depending on which
side of the environment view they are on, and the menus track better with
scrolling (around the arrow rather than around the top of the menu).

R=benjamin.saller
CC=
https://codereview.appspot.com/6766052

Expand All Messages | Collapse All Messages