Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10743)

Issue 6765051: Enable TLS on websockets.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by frankban
Modified:
11 years, 6 months ago
Reviewers:
hazmat, mp+131358
Visibility:
Public.

Description

Enable TLS on websockets. Fixed how we dynamically switch the wrapped protocol when a secure connection is used. The server now uses TLS both for web and websocket connections. The https and wss connections use the same port. https://code.launchpad.net/~frankban/juju/enable-tls/+merge/131358 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enable TLS on websockets. #

Patch Set 3 : Enable TLS on websockets. #

Patch Set 4 : Enable TLS on websockets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -10 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
improv.py View 1 5 chunks +12 lines, -3 lines 0 comments Download
M juju/agents/api.py View 1 5 chunks +38 lines, -4 lines 0 comments Download
A juju/agents/keys/juju.crt View 1 1 chunk +19 lines, -0 lines 0 comments Download
A juju/agents/keys/juju.key View 1 1 chunk +27 lines, -0 lines 0 comments Download
M juju/lib/websockets.py View 1 chunk +5 lines, -1 line 0 comments Download
M juju/providers/local/__init__.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M juju/providers/local/agent.py View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
frankban
Please take a look.
11 years, 6 months ago (2012-10-25 09:48:12 UTC) #1
hazmat
looks good, one minor, let me know what you think. https://codereview.appspot.com/6765051/diff/1/juju/agents/api.py File juju/agents/api.py (right): https://codereview.appspot.com/6765051/diff/1/juju/agents/api.py#newcode44 ...
11 years, 6 months ago (2012-10-26 07:26:21 UTC) #2
frankban
11 years, 6 months ago (2012-10-29 09:30:24 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b