Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3221)

Issue 6765050: Ambiguous relation improvements

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by matthew.scott
Modified:
11 years, 6 months ago
Reviewers:
mp+131325
Visibility:
Public.

Description

Ambiguous relation improvements Ambiguous relations sorted in menu; relations aren't indented; cancel button says 'Cancel' and is styled; click to add relation is fixed; pending relation line shown with click to add relation, and lingers when menu is open. https://code.launchpad.net/~makyo/juju-gui/ambiguous-minors/+merge/131325 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ambiguous relation improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/ambiguousRelationList.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/environment.js View 1 7 chunks +30 lines, -8 lines 0 comments Download
M lib/views/stylesheet.less View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3
matthew.scott
Please take a look.
11 years, 6 months ago (2012-10-25 07:26:27 UTC) #1
benjamin.saller
LGTM https://codereview.appspot.com/6765050/diff/1/app/views/environment.js File app/views/environment.js (right): https://codereview.appspot.com/6765050/diff/1/app/views/environment.js#newcode1478 app/views/environment.js:1478: return a[0].name + a[1].name < b[0].name + b[1].name; ...
11 years, 6 months ago (2012-10-25 15:24:37 UTC) #2
matthew.scott
11 years, 6 months ago (2012-10-26 06:17:16 UTC) #3
*** Submitted:

Ambiguous relation improvements

Ambiguous relations sorted in menu; relations aren't indented; cancel button
says 'Cancel' and is styled; click to add relation is fixed; pending relation
line shown with click to add relation, and lingers when menu is open.

R=benjamin.saller
CC=
https://codereview.appspot.com/6765050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b