Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 6761057: Bake's code review

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by danielcamara
Modified:
9 years, 7 months ago
Reviewers:
Alex Afanasyev
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Bake's code review

Patch Set 1 #

Patch Set 2 : Bake's code review #

Total comments: 3

Patch Set 3 : Alex suggestions - Bake Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M bake/Bake.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M bake/ModuleSource.py View 1 2 3 chunks +22 lines, -5 lines 0 comments Download
M test/TestModuleSource.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Alex Afanasyev
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py File bake/ModuleSource.py (right): http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode206 bake/ModuleSource.py:206: ] Not sure if anybody yet uses it, but ...
9 years, 8 months ago (2012-10-25 15:41:16 UTC) #1
danielcamara
9 years, 7 months ago (2012-11-05 11:12:31 UTC) #2
On 2012/10/25 15:41:16, Alex Afanasyev wrote:
> http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py
> File bake/ModuleSource.py (right):
> 
>
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode206
> bake/ModuleSource.py:206: ]
> Not sure if anybody yet uses it, but there are a couple of other compression
> formats that are used by some developers and may be useful to include here. 
On
> top of my head is xz.
  
 Ok, I am adding the options for .xz and .tar.xz, if you have any other that you
think is useful, let me know. 

> 
>
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode330
> bake/ModuleSource.py:330: 
> This can be extended to MacOS with macports (port command), as it is the
easiest
> way to install all NS-3 dependencies (including ones for the visualizer) on
OSX.

 Great, thanks for the suggestion! I am not exactly a proficient MAC user, but
as far as I understood from the macports help page, it will not be hard to add
it to Bake.  I will do it, but I will not release until I manage to test it
properly.   

> 
>
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode658
> bake/ModuleSource.py:658: 
> I think "checkout" command here is totally wrong.  It should be "merge".
> 

 You are right. I will change it! 

> First of all, if it is an intended behavior, then name "update" is really
> misleading, because instead of updating the code, it is doing re-checkout. 
> Second of all, I think for mercurial and bzr, you do pull, which equivalent to
> fetch&&merge in git (I'm not 100% sure).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b