Issue 6752050: code review 6752050: cmd/api: new testdata for http://codereview.appspot.com...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6752050: code review 6752050: cmd/api: new testdata for http://codereview.appspot.com...

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by visualfc

Modified:
10 years, 11 months ago

Reviewers:
golang-dev, bradfitz

CC:
golang-dev

Visibility:
Public.

Description

cmd/api: new testdata for http://codereview.appspot.com/6742050/

Patch Set 1 #

Patch Set 2 : diff -r 8d919bfe75d3 https://code.google.com/p/go #

Patch Set 3 : diff -r 8d919bfe75d3 https://code.google.com/p/go #

Patch Set 4 : diff -r d81bcf447d65 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -0 lines)			Patch
	A	src/cmd/api/testdata/src/pkg/p4/golden.txt	View	1 2 3	1 chunk	+31 lines, -0 lines	0 comments	Download
	A	src/cmd/api/testdata/src/pkg/p4/p4.go	View	1 2 3	1 chunk	+99 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

visualfc

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org), I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2012-10-23 09:06:03 UTC) #1

visualfc

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org, golang-dev@googlegroups.com), Please take another look.

11 years, 6 months ago (2012-10-26 03:32:56 UTC) #2

bradfitz

10 years, 11 months ago (2013-06-04 22:41:57 UTC) #3

R=close

This is too big of a change for me to maintain. I'd prefer people fork cmd/api
elsewhere if they'd like to make big changes to it for their own use.

Expand All Messages | Collapse All Messages