Issue 6742045: ec2: add image handling support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6742045: ec2: add image handling support

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by niemeyer

Modified:
11 years, 6 months ago

Reviewers:
mp+130409

Visibility:
Public.

Description

ec2: add image handling support This is integrating the merge proposal from Andrey Mirtchovski with trivial tweaks: https://code.launchpad.net/~mirtchovski/goamz/ec2/+merge/129325 https://code.launchpad.net/~niemeyer/goamz/image-support/+merge/130409 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ec2: add image handling support #

Patch Set 3 : ec2: add image handling support #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+392 lines, -12 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ec2/ec2.go	View	1	5 chunks	+172 lines, -6 lines	0 comments	Download
M	ec2/ec2_test.go	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
M	ec2/ec2i_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ec2/ec2t_test.go	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	ec2/responses_test.go	View		1 chunk	+90 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Cross-checked tweaks with Andrey: <f2f> niemeyer: sounds good.

11 years, 6 months ago (2012-10-18 19:06:06 UTC) #3

niemeyer

11 years, 6 months ago (2012-10-18 19:08:57 UTC) #4

*** Submitted:

ec2: add image handling support

This is integrating the merge proposal from Andrey Mirtchovski with
trivial tweaks:

https://code.launchpad.net/~mirtchovski/goamz/ec2/+merge/129325

R=
CC=
https://codereview.appspot.com/6742045

Expand All Messages | Collapse All Messages