Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 6739054: Remove bash-specific syntax from traceurc. (trivial patch) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by usrbincc
Modified:
13 years, 8 months ago
Reviewers:
slightlylate, arv
CC:
traceur-compiler-reviews_googlegroups.com
Base URL:
https://code.google.com/p/traceur-compiler/@master
Visibility:
Public.

Description

Remove bash-specific syntax from traceurc. ${parameter:offset:length} and 'exit -1' are a bash-specific features. ${parameter#prefix_to_remove} and 'exit 1' are passable replacements this case. This is a problem on Debian-based systems, or any system where /bin/sh is not a symlink to /bin/bash. Syntax tested with bash, dash and Busybox ash, and should work with BSD sh, according to the man page. BUG=http://code.google.com/p/traceur-compiler/issues/detail?id=111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M traceurc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
usrbincc
This is one of two small usability patches. This one allows traceurc to run unmodified ...
13 years, 8 months ago (2012-10-22 22:19:05 UTC) #1
arv
LGTM Does build/build have any issues?
13 years, 8 months ago (2012-10-23 13:36:29 UTC) #2
arv
Committed as http://code.google.com/p/traceur-compiler/source/detail?r=1fb3ebaffe063be92c108080de7fa8a415ac788d
13 years, 8 months ago (2012-10-23 14:34:12 UTC) #3
usrbincc
Oops, I didn't realize the typos until I saw the commit. It was originally: x ...
13 years, 8 months ago (2012-10-23 20:23:38 UTC) #4
usrbincc
13 years, 8 months ago (2012-11-02 17:03:44 UTC) #5
On 2012/10/23 13:36:29, arv-chromium wrote:
> LGTM
>
> Does build/build have any issues?
I missed this question last time. For the record, I did not notice any
/bin/sh compatibility issues running build/build
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b