Issue 6736058: uniter: hook tests more careful

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6736058: uniter: hook tests more careful

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by fwereade

Modified:
11 years, 6 months ago

Reviewers:
mp+130749

Visibility:
Public.

Description

uniter: hook tests more careful we now only report hooks to have run once they have completed (rather than just when they've started) https://code.launchpad.net/~fwereade/juju-core/uniter-careful-wait-hooks/+merge/130749 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : uniter: hook tests more careful #

Patch Set 3 : uniter: hook tests more careful #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
	A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/uniter/uniter_test.go	View	1 2	1 chunk	+27 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

11 years, 6 months ago (2012-10-25 11:06:54 UTC) #4

*** Submitted:

uniter: hook tests more careful

we now only report hooks to have run once they have completed (rather than
just when they've started)

R=niemeyer
CC=
https://codereview.appspot.com/6736058

Expand All Messages | Collapse All Messages