Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(527)

Issue 6735048: Stop sending the app object to views.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by benji
Modified:
11 years, 6 months ago
Reviewers:
mp+130552
Visibility:
Public.

Description

Stop sending the app object to views. This refactoring is intended to flatten the namespace views use and make the values available to views both more constrained and better specified. https://code.launchpad.net/~benji/juju-gui/tweak-show_environment-2/+merge/130552 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Stop sending the app object to views. #

Patch Set 3 : Stop sending the app object to views. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+656 lines, -724 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 8 chunks +24 lines, -23 lines 0 comments Download
M app/templates/service-footer-common-controls.partial View 1 2 chunks +2 lines, -2 lines 0 comments Download
M app/views/charm-search.js View 1 2 9 chunks +94 lines, -19 lines 0 comments Download
M app/views/environment.js View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M app/views/service.js View 1 31 chunks +84 lines, -69 lines 0 comments Download
M app/views/unit.js View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M app/views/utils.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/test_application_notifications.js View 1 8 chunks +269 lines, -298 lines 0 comments Download
M test/test_charm_configuration.js View 1 2 6 chunks +26 lines, -35 lines 0 comments Download
M test/test_charm_search.js View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M test/test_environment_view.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test_notifications.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/test_service_config_view.js View 1 9 chunks +17 lines, -45 lines 0 comments Download
M test/test_service_view.js View 1 2 34 chunks +75 lines, -139 lines 0 comments Download
M test/test_unit_view.js View 1 13 chunks +42 lines, -72 lines 0 comments Download

Messages

Total messages: 6
benji
Please take a look.
11 years, 7 months ago (2012-10-19 14:16:34 UTC) #1
hazmat
mostly procedural, looks good to me.
11 years, 7 months ago (2012-10-19 19:41:34 UTC) #2
hazmat
noticing a few errors in practice. changing units is broken. still investigating for others.
11 years, 7 months ago (2012-10-19 19:44:34 UTC) #3
hazmat
On 2012/10/19 19:44:34, hazmat wrote: > noticing a few errors in practice. changing units is ...
11 years, 7 months ago (2012-10-19 19:46:33 UTC) #4
benji
Please take a look.
11 years, 7 months ago (2012-10-25 09:59:54 UTC) #5
benji
11 years, 6 months ago (2012-10-29 10:02:54 UTC) #6
*** Submitted:

Stop sending the app object to views.

This refactoring is intended to flatten the namespace views use and make the
values available to views both more constrained and better specified.

R=hazmat
CC=
https://codereview.appspot.com/6735048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b