Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3050)

Issue 6734049: state: RelationEndpoint => Endpoint

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by fwereade
Modified:
11 years, 6 months ago
Reviewers:
mp+130594
Visibility:
Public.

Description

state: RelationEndpoint => Endpoint ...also added an ImplementedBy method, for determining whether a given charm offers a compatible endpoint, and tests which had apparently somehow not been written. https://code.launchpad.net/~fwereade/juju-core/state-relation-endpoint/+merge/130594 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : state: RelationEndpoint => Endpoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -116 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/deploy.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/deploy_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/charm.go View 2 chunks +6 lines, -2 lines 0 comments Download
A state/endpoint.go View 1 1 chunk +92 lines, -0 lines 0 comments Download
A state/endpoint_test.go View 1 1 chunk +110 lines, -0 lines 0 comments Download
M state/life_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relation.go View 5 chunks +8 lines, -61 lines 0 comments Download
M state/relation_internal_test.go View 1 chunk +8 lines, -8 lines 0 comments Download
M state/relation_test.go View 17 chunks +25 lines, -25 lines 0 comments Download
M state/service_test.go View 6 chunks +8 lines, -8 lines 0 comments Download
M state/state.go View 3 chunks +3 lines, -3 lines 0 comments Download
M state/state_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/context_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/uniter/filter_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/relationer_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/uniter_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
fwereade
Please take a look.
11 years, 6 months ago (2012-10-19 16:08:56 UTC) #1
niemeyer
LGTM assuming a better name for Match. https://codereview.appspot.com/6734049/diff/1/state/endpoint.go File state/endpoint.go (right): https://codereview.appspot.com/6734049/diff/1/state/endpoint.go#newcode61 state/endpoint.go:61: // Match ...
11 years, 6 months ago (2012-10-25 08:23:07 UTC) #2
fwereade
*** Submitted: state: RelationEndpoint => Endpoint ...also added an ImplementedBy method, for determining whether a ...
11 years, 6 months ago (2012-10-25 09:00:46 UTC) #3
fwereade
11 years, 6 months ago (2012-10-25 09:01:08 UTC) #4
On 2012/10/25 08:23:07, niemeyer wrote:
> LGTM assuming a better name for Match.
> 
> https://codereview.appspot.com/6734049/diff/1/state/endpoint.go
> File state/endpoint.go (right):
> 
> https://codereview.appspot.com/6734049/diff/1/state/endpoint.go#newcode61
> state/endpoint.go:61: // Match returns whether the endpoint matches the
supplied
> charm.
> endpoint.ImplementedBy(charm) sounds about right. WDYT?

Sounds perfect, thanks :).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b