Issue 6734043: ec2: sort keys before encoding

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6734043: ec2: sort keys before encoding (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dave

Modified:
11 years, 5 months ago

Reviewers:
mp+130272

Visibility:
Public.

Description

ec2: sort keys before encoding Fixes issue #1061941. https://code.launchpad.net/~dave-cheney/goamz/002-sign-sorting/+merge/130272 (do not edit description out of merge proposal)

Patch Set 2 : ec2: sort keys before encoding #

Patch Set 3 : ec2: sort keys before encoding #

Total comments: 4

Patch Set 4 : ec2: sort keys before encoding #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -38 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ec2/ec2.go	View	1 2 3	7 chunks	+12 lines, -27 lines	0 comments	Download
M	ec2/ec2i_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ec2/ec2t_test.go	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	ec2/sign.go	View	1 2 3	1 chunk	+12 lines, -5 lines	0 comments	Download
M	ec2/sign_test.go	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

Awesome, thanks! LGTM, with a couple of trivial suggestions: https://codereview.appspot.com/6734043/diff/7001/ec2/ec2.go File ec2/ec2.go (right): https://codereview.appspot.com/6734043/diff/7001/ec2/ec2.go#newcode183 ec2/ec2.go:183: ...

11 years, 6 months ago (2012-10-26 14:16:21 UTC) #5

dave_cheney.net

11 years, 5 months ago (2012-10-28 16:05:52 UTC) #6

*** Submitted:

ec2: sort keys before encoding

Fixes issue #1061941.

R=niemeyer
CC=
https://codereview.appspot.com/6734043

https://codereview.appspot.com/6734043/diff/7001/ec2/ec2.go
File ec2/ec2.go (right):

https://codereview.appspot.com/6734043/diff/7001/ec2/ec2.go#newcode183
ec2/ec2.go:183: func buildParamsList(params map[string]string, ids []string,
label string) {
Done. The function was inspired by Boto, so shared its name.

https://codereview.appspot.com/6734043/diff/7001/ec2/sign.go
File ec2/sign.go (right):

https://codereview.appspot.com/6734043/diff/7001/ec2/sign.go#newcode22
ec2/sign.go:22: // aws specifies that the parameters in a signed request must
On 2012/10/26 14:16:21, niemeyer wrote:
> s/aws/AWS/

Done.

Expand All Messages | Collapse All Messages