Preserve zoom settings in the environment view.

Preserve zoom settings in the environment view.

The zoom scale and translate are preserved after a scene redraw
(e.g. when adding/removing relations, destroying services,
navigating to the service view and back to the front page).

https://code.launchpad.net/~frankban/juju-gui/preserve-zoom/+merge/130087

(do not edit description out of merge proposal)

[frankban, 2012-10-17 11:01:11]

Please take a look.

[matthew.scott, 2012-10-17 14:11:34]

Trainee review by Matthew.  Looks good to me and works well.  Thanks for the
catch on double-clicking a service causing a zoom!  One minor about a comment
below, and as always, wait for the blessed review.

https://codereview.appspot.com/6720048/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6720048/diff/1/app/views/environment.js#newcod...
app/views/environment.js:1163: // Store the current value of translate by
copying the event array
Minor: I know the above line was there before, but maybe it deserves a comment
as well, possibly just merged with this comment.

[frankban, 2012-10-17 14:24:04]

Please take a look.

[frankban, 2012-10-17 14:25:41]

Thanks for the review Matthew.

https://codereview.appspot.com/6720048/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6720048/diff/1/app/views/environment.js#newcod...
app/views/environment.js:1163: // Store the current value of translate by
copying the event array
On 2012/10/17 14:11:34, matthew.scott wrote:
> Minor: I know the above line was there before, but maybe it deserves a comment
> as well, possibly just merged with this comment.

Done.

[benjamin.saller, 2012-10-17 14:35:11]

LGTM with the minor noted.

Thanks

https://codereview.appspot.com/6720048/diff/4001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6720048/diff/4001/app/views/environment.js#new...
app/views/environment.js:243: if (sourceEvent.type === 'dblclick' &&
.on("dblclick.zoom", null) during the bind will remove the dblclick behavior.

[frankban, 2012-10-17 14:55:21]

Please take a look.

[frankban, 2012-10-17 14:56:54]

Thanks Ben.

https://codereview.appspot.com/6720048/diff/4001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6720048/diff/4001/app/views/environment.js#new...
app/views/environment.js:243: if (sourceEvent.type === 'dblclick' &&
On 2012/10/17 14:35:11, benjamin.saller wrote:
> .on("dblclick.zoom", null) during the bind will remove the dblclick behavior.

Done.

[frankban, 2012-10-17 15:49:02]

*** Submitted:

Preserve zoom settings in the environment view.

The zoom scale and translate are preserved after a scene redraw
(e.g. when adding/removing relations, destroying services,
navigating to the service view and back to the front page).

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6720048