Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(415)

Issue 6718048: Service health graphs consistently rendered

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by matthew.scott
Modified:
12 years, 5 months ago
Reviewers:
mp+130005
Visibility:
Public.

Description

Service health graphs consistently rendered d3 was sorting by the largest value, now sorts in the proper order: error - pending - running https://code.launchpad.net/~makyo/juju-gui/consistent-health-graph/+merge/130005 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Service health graphs consistently rendered #

Patch Set 3 : Service health graphs consistently rendered #

Patch Set 4 : Service health graphs consistently rendered #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/environment.js View 1 2 3 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
12 years, 5 months ago (2012-10-16 23:03:52 UTC) #1
benjamin.saller
LGTM https://codereview.appspot.com/6718048/diff/1/app/views/environment.js File app/views/environment.js (right): https://codereview.appspot.com/6718048/diff/1/app/views/environment.js#newcode784 app/views/environment.js:784: }); This looks fine to me, can we ...
12 years, 5 months ago (2012-10-17 18:17:47 UTC) #2
matthew.scott
*** Submitted: Service health graphs consistently rendered d3 was sorting by the largest value, now ...
12 years, 5 months ago (2012-10-17 19:39:45 UTC) #3
matthew.scott
12 years, 5 months ago (2012-10-17 21:13:59 UTC) #4
*** Submitted:

Service health graphs consistently rendered

d3 was sorting by the largest value, now sorts in the proper order: error -
pending - running

R=
CC=
https://codereview.appspot.com/6718048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b