code review 67170043: syscall: make mkerrors.sh work with clang

syscall: make mkerrors.sh work with clang

[mikio, 2014-02-22 01:23:07]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2014-02-22 02:55:07]

I think those who only have clang (e.g. FreeBSD) can modify the file fairly
easily
(just change the GCC=gcc line), and this script is only intend to be run by
a small group of people, so perhaps we don't need to make the change.

[mikio, 2014-02-22 03:14:54]

please say "not lgtm" if you dislike or you think it's not worth.

[minux1, 2014-02-22 03:23:38]

On Fri, Feb 21, 2014 at 10:14 PM, Mikio Hara <mikioh.mikioh@gmail.com>wrote:

> please say "not lgtm" if you dislike or you think it's not worth.
>
Basically I'm on the fence. Let's wait for others to make the decision.

[gobot, 2014-02-22 03:24:38]

R=iant@golang.org (assigned by minux.ma@gmail.com)

[iant, 2014-02-24 05:55:29]

LGTM

This is a minor change but I think it's fine.

[mikio, 2014-02-24 07:34:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=3cf533be5e36 ***

syscall: make mkerrors.sh work with clang

LGTM=iant
R=golang-codereviews, minux.ma, gobot, iant
CC=golang-codereviews
https://codereview.appspot.com/67170043

[gobot, 2014-02-24 07:39:13]

This CL appears to have broken the darwin-386-cheney builder.

[dave_cheney.net, 2014-02-24 07:53:17]

This is a real but unrelated failure, Josh has opened a bug. 

> On 24 Feb 2014, at 18:39, gobot@golang.org wrote:
> 
> This CL appears to have broken the darwin-386-cheney builder.
> 
> https://codereview.appspot.com/67170043/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.