environs: added error in case of illegal mode

environs: added error in case of illegal mode

Changed OpenPorts/ClosePorts/Ports in dummy and ec2 to
check if the correct firewall mode is set. That is "global"
for operations on the environ and "instance" for operations
on instances.

https://code.launchpad.net/~themue/juju-core/go-environs-mode-errors/+merge/130061

(do not edit description out of merge proposal)

[TheMue, 2012-10-17 09:51:41]

Please take a look.

[niemeyer, 2012-10-17 21:27:27]

https://codereview.appspot.com/6715048/diff/1/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/6715048/diff/1/environs/dummy/environs.go#newc...
environs/dummy/environs.go:494: env:       e,
Doesn't look right. One environment state may be linked to from many environment
instances, and one instance is associated to one state.

Please have a look at the code you reverted to see how to do that properly.

[TheMue, 2012-10-18 11:20:19]

Please take a look.

https://codereview.appspot.com/6715048/diff/1/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/6715048/diff/1/environs/dummy/environs.go#newc...
environs/dummy/environs.go:494: env:       e,
On 2012/10/17 21:27:28, niemeyer wrote:
> Doesn't look right. One environment state may be linked to from many
environment
> instances, and one instance is associated to one state.
> 
> Please have a look at the code you reverted to see how to do that properly.

Done.

[niemeyer, 2012-10-19 00:50:04]

LGTM either way. It's not worth spending more time on this.

https://codereview.appspot.com/6715048/diff/5001/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/6715048/diff/5001/environs/dummy/environs.go#n...
environs/dummy/environs.go:498: firewallMode: e.Config().FirewallMode(),
That's not what was being done. The firewall mode is the same for all instances,
and all environments. Here is the diff for reference:

http://paste.ubuntu.com/1288133/

[TheMue, 2012-10-19 09:18:44]

*** Submitted:

environs: added error in case of illegal mode

Changed OpenPorts/ClosePorts/Ports in dummy and ec2 to
check if the correct firewall mode is set. That is "global"
for operations on the environ and "instance" for operations
on instances.

R=
CC=
https://codereview.appspot.com/6715048