state: fix AddUnit when called concurrently

state: fix AddUnit when called concurrently

The right fix is more involved, but this should
do the trick in the meantime.

https://code.launchpad.net/~rogpeppe/juju-core/133-fix-assign-to-unused-machine/+merge/129941

(do not edit description out of merge proposal)

[rog, 2012-10-16 16:37:42]

Please take a look.

[niemeyer, 2012-10-16 16:51:08]

LGTM

[dave_cheney.net, 2012-10-17 01:32:04]

On 2012/10/16 16:51:08, niemeyer wrote:
> LGTM

Thanks rog. This will probably work, but the test doesn't work. I rolled back
state.go and the test passed.

[rog, 2012-10-17 09:04:50]

On 17 October 2012 02:32,  <dave@cheney.net> wrote:
> On 2012/10/16 16:51:08, niemeyer wrote:
>>
>> LGTM
>
>
> Thanks rog. This will probably work, but the test doesn't work. I rolled
> back state.go and the test passed.

Please could you let me know how the test failed.
It passes for me.

[dave_cheney.net, 2012-10-17 12:35:27]

The test failed to fail when I ran it against the unmodified state.go. 

On 17/10/2012, at 20:04, roger peppe <rogpeppe@gmail.com> wrote:

> On 17 October 2012 02:32,  <dave@cheney.net> wrote:
>> On 2012/10/16 16:51:08, niemeyer wrote:
>>> 
>>> LGTM
>> 
>> 
>> Thanks rog. This will probably work, but the test doesn't work. I rolled
>> back state.go and the test passed.
> 
> Please could you let me know how the test failed.
> It passes for me.

[rog, 2012-10-17 14:20:23]

On 17 October 2012 13:35, Dave Cheney <dave@cheney.net> wrote:
> The test failed to fail when I ran it against the unmodified state.go.

how does it fail when you run it against the modified state.go ?


> On 17/10/2012, at 20:04, roger peppe <rogpeppe@gmail.com> wrote:
>
>> On 17 October 2012 02:32,  <dave@cheney.net> wrote:
>>> On 2012/10/16 16:51:08, niemeyer wrote:
>>>>
>>>> LGTM
>>>
>>>
>>> Thanks rog. This will probably work, but the test doesn't work. I rolled
>>> back state.go and the test passed.
>>
>> Please could you let me know how the test failed.
>> It passes for me.

[rog, 2012-10-19 12:25:13]

*** Submitted:

state: fix AddUnit when called concurrently

The right fix is more involved, but this should
do the trick in the meantime.

R=niemeyer, dfc
CC=
https://codereview.appspot.com/6713045