Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1529)

Issue 6713044: Blender password text input

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by jiri.hnidek
Modified:
6 years, 10 months ago
Reviewers:
bf-codereview, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Blender password text input

Patch Set 1 #

Total comments: 5

Patch Set 2 : New patch of Blender password text input #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -22 lines) Patch
source/blender/blenlib/BLI_string_utf8.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M source/blender/blenlib/intern/string_utf8.c View 1 1 chunk +32 lines, -18 lines 0 comments Download
source/blender/editors/interface/interface_handlers.c View 1 3 chunks +70 lines, -1 line 0 comments Download
source/blender/editors/interface/interface_intern.h View 1 2 chunks +3 lines, -1 line 0 comments Download
source/blender/editors/interface/interface_widgets.c View 1 2 chunks +7 lines, -2 lines 0 comments Download
M source/blender/makesrna/RNA_types.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesrna/intern/makesrna.c View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/python/intern/bpy_props.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11
jiri.hnidek
6 years, 11 months ago (2012-10-16 14:07:44 UTC) #1
jiri.hnidek
On 2012/10/16 14:07:44, jiri.hnidek wrote: Hi, I use this for first time. There are some ...
6 years, 11 months ago (2012-10-16 14:14:41 UTC) #2
jiri.hnidek
I added some comments to source code. https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c File source/blender/editors/interface/interface_widgets.c (right): https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c#newcode985 source/blender/editors/interface/interface_widgets.c:985: Following code ...
6 years, 11 months ago (2012-10-22 10:09:16 UTC) #3
jiri.hnidek
On 2012/10/16 14:07:44, jiri.hnidek wrote: I was asked by Ton to add use cases and ...
6 years, 11 months ago (2012-10-22 12:11:24 UTC) #4
brechtvl
https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c File source/blender/editors/interface/interface_widgets.c (right): https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c#newcode953 source/blender/editors/interface/interface_widgets.c:953: * \brief This function convert password string that should ...
6 years, 11 months ago (2012-10-22 17:16:42 UTC) #5
brechtvl
It seems that the 'bullet' character does work with our font, which looks pretty good ...
6 years, 11 months ago (2012-10-22 17:29:53 UTC) #6
jiri.hnidek
On 2012/10/22 17:29:53, brechtvl wrote: > It seems that the 'bullet' character does work with ...
6 years, 11 months ago (2012-10-22 19:39:32 UTC) #7
brechtvl
If there's issues placing the cursor, then I fear using an asterisk will not work ...
6 years, 11 months ago (2012-10-22 20:02:46 UTC) #8
jiri.hnidek
On 2012/10/22 20:02:46, brechtvl wrote: > If there's issues placing the cursor, then I fear ...
6 years, 11 months ago (2012-10-22 20:22:30 UTC) #9
brechtvl
I can still see issue when typing such UTF-8 characters, even with the asterisks, the ...
6 years, 10 months ago (2012-10-25 20:18:23 UTC) #10
jiri.hnidek
6 years, 10 months ago (2012-10-26 12:35:40 UTC) #11
On 2012/10/25 20:18:23, brechtvl wrote:
> I can still see issue when typing such UTF-8 characters, even with the
> asterisks, the cursor position and selection are drawing wrong. Also placing
the
> cursor gives issue, but that's because ui_textedit_set_cursor_pos does not
take
> things into account.
> 
> Anyway, I modified the implementation, hope you don't mind, patch here:
> http://www.pasteall.org/36595/diff

Hi Brecht,
thanks for your patch. It seems that everybody use git for blender development
despite blender has official svn repository ;-). BTW: I found this tool very
helpful:

https://gist.github.com/721622

I uploaded your patch with small modifications to codereview. I hope that it was
uploaded corectly, because scripting for uploading was ended with some weired
errors. Anyway, I made BLI_strlen_utf8_char not static function and I added more
comments to source code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b