Issue 67020043: code review 67020043: reflect: better error for walking through nil embedded ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67020043: code review 67020043: reflect: better error for walking through nil embedded ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 4 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

reflect: better error for walking through nil embedded struct pointer The old error was "call of reflect.Value.Field on ptr Value". http://play.golang.org/p/Zm-ZbQaPeR

Patch Set 2 : diff -r b5eda189b974 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b5eda189b974 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r b5eda189b974 https://code.google.com/p/go/ #

Patch Set 5 : diff -r ca78452beddf https://code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	src/pkg/reflect/all_test.go	View	1 2 3	2 chunks	+24 lines, -0 lines	0 comments	Download
	M	src/pkg/reflect/value.go	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2014-02-21 16:35:34 UTC) #1

https://codereview.appspot.com/67020043/diff/30001/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): https://codereview.appspot.com/67020043/diff/30001/src/pkg/reflect/value.go#newcode894 src/pkg/reflect/value.go:894: panic("reflect: nil embedded struct pointer during field lookup") that's ...

11 years, 4 months ago (2014-02-21 17:26:20 UTC) #2

rsc

On 2014/02/21 17:26:20, r wrote: > https://codereview.appspot.com/67020043/diff/30001/src/pkg/reflect/value.go > File src/pkg/reflect/value.go (right): > > https://codereview.appspot.com/67020043/diff/30001/src/pkg/reflect/value.go#newcode894 > ...

11 years, 4 months ago (2014-02-21 17:29:59 UTC) #3

rsc

11 years, 4 months ago (2014-02-21 18:51:25 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=9df0e0777b28 ***

reflect: better error for walking through nil embedded struct pointer

The old error was "call of reflect.Value.Field on ptr Value".

http://play.golang.org/p/Zm-ZbQaPeR

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/67020043

Expand All Messages | Collapse All Messages