Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 6700047: code review 6700047: archive/tar: read/write extended pax/gnu tar archives (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by shanemhansen
Modified:
9 years, 6 months ago
Reviewers:
CC:
dsymonds, dfc, rog, remyoudompheng, chressie1, rsc, golang-dev
Visibility:
Public.

Description

archive/tar: read/write extended pax/gnu tar archives Support reading pax archives and applying extended attributes like long names, subsecond mtime resolutions, etc. Default to writing pax archives for long file and link names. Support reading gnu archives using the ././@LongLink extended header for file name and link target. Fixes issue 3300

Patch Set 1 #

Patch Set 2 : diff -r 39b31d81b947 https://code.google.com/p/go #

Total comments: 23

Patch Set 3 : diff -r 39b31d81b947 https://code.google.com/p/go #

Total comments: 18

Patch Set 4 : diff -r 39b31d81b947 https://code.google.com/p/go #

Total comments: 10

Patch Set 5 : diff -r 39b31d81b947 https://code.google.com/p/go #

Total comments: 22

Patch Set 6 : diff -r 39b31d81b947 https://code.google.com/p/go #

Total comments: 24

Patch Set 7 : diff -r 93dc7f0e302b https://code.google.com/p/go #

Total comments: 12

Patch Set 8 : diff -r 93dc7f0e302b https://code.google.com/p/go #

Total comments: 8

Patch Set 9 : diff -r 93dc7f0e302b https://code.google.com/p/go #

Total comments: 4

Patch Set 10 : diff -r 135a1d6e0a91 https://code.google.com/p/go #

Patch Set 11 : diff -r 135a1d6e0a91 https://code.google.com/p/go #

Total comments: 8

Patch Set 12 : diff -r 1399878c6731 https://code.google.com/p/go #

Patch Set 13 : diff -r 1399878c6731 https://code.google.com/p/go #

Total comments: 9

Patch Set 14 : diff -r 439cb8bad388 https://code.google.com/p/go #

Patch Set 15 : diff -r 439cb8bad388 https://code.google.com/p/go #

Patch Set 16 : diff -r 439cb8bad388 https://code.google.com/p/go #

Patch Set 17 : diff -r 439cb8bad388 https://code.google.com/p/go #

Patch Set 18 : diff -r 439cb8bad388 https://code.google.com/p/go #

Total comments: 19

Patch Set 19 : diff -r 439cb8bad388 https://code.google.com/p/go #

Patch Set 20 : diff -r 439cb8bad388 https://code.google.com/p/go #

Total comments: 4

Patch Set 21 : diff -r 439cb8bad388 https://code.google.com/p/go #

Total comments: 9

Patch Set 22 : diff -r 439cb8bad388 https://code.google.com/p/go #

Patch Set 23 : diff -r 439cb8bad388 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -9 lines) Patch
M src/pkg/archive/tar/common.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +9 lines, -0 lines 0 comments Download
M src/pkg/archive/tar/reader.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +176 lines, -3 lines 0 comments Download
M src/pkg/archive/tar/reader_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +105 lines, -1 line 0 comments Download
A src/pkg/archive/tar/testdata/pax.tar View 1 Binary file 0 comments Download
A src/pkg/archive/tar/testdata/ustar.tar View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 Binary file 0 comments Download
M src/pkg/archive/tar/writer.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 5 chunks +102 lines, -5 lines 0 comments Download
M src/pkg/archive/tar/writer_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 74
shanemhansen
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2012-10-15 23:07:48 UTC) #1
dsymonds
Please read http://golang.org/doc/contribute.html and http://golang.org/doc/effective_go.html, especially the part about matching the existing coding style. The ...
9 years, 10 months ago (2012-10-16 00:53:12 UTC) #2
dfc
Thank you for taking a stab at this. Some initial comments below. What is the ...
9 years, 10 months ago (2012-10-16 00:54:38 UTC) #3
shanemhansen
On 2012/10/16 00:54:38, dfc wrote: > Thank you for taking a stab at this. Some ...
9 years, 10 months ago (2012-10-16 02:13:17 UTC) #4
shanemhansen
Sorry for the spam, just realized my comments didn't make it out with my last ...
9 years, 10 months ago (2012-10-16 02:14:26 UTC) #5
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-10-16 03:17:40 UTC) #6
dfc
https://codereview.appspot.com/6700047/diff/5/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/5/src/pkg/archive/tar/reader.go#newcode153 src/pkg/archive/tar/reader.go:153: hdr.Size = int64(size) Should there be a default condition ...
9 years, 10 months ago (2012-10-16 03:25:12 UTC) #7
shanemhansen
https://codereview.appspot.com/6700047/diff/5/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/5/src/pkg/archive/tar/reader.go#newcode153 src/pkg/archive/tar/reader.go:153: hdr.Size = int64(size) On 2012/10/16 03:25:12, dfc wrote: > ...
9 years, 10 months ago (2012-10-16 04:05:04 UTC) #8
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-10-16 04:05:35 UTC) #9
dfc
Thank you. I would like to see unit tests for the parsing routines. https://codereview.appspot.com/6700047/diff/5009/src/pkg/archive/tar/reader.go File ...
9 years, 10 months ago (2012-10-16 04:24:56 UTC) #10
rog
A few trivial comments on the documentation style. https://codereview.appspot.com/6700047/diff/5009/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/5009/src/pkg/archive/tar/reader.go#newcode104 src/pkg/archive/tar/reader.go:104: // ...
9 years, 10 months ago (2012-10-16 10:52:03 UTC) #11
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-10-16 17:09:49 UTC) #12
shanemhansen
https://codereview.appspot.com/6700047/diff/5009/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/5009/src/pkg/archive/tar/reader.go#newcode104 src/pkg/archive/tar/reader.go:104: // Merge well known headers according to PAX standard. ...
9 years, 10 months ago (2012-10-16 17:09:53 UTC) #13
dsymonds
Sorry for the delay. There's a lot to digest here. I've only had a good ...
9 years, 10 months ago (2012-10-22 06:29:14 UTC) #14
remyoudompheng
https://codereview.appspot.com/6700047/diff/18001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/18001/src/pkg/archive/tar/reader.go#newcode243 src/pkg/archive/tar/reader.go:243: // cString parse bytes as a NUL-terminated C-style string. ...
9 years, 10 months ago (2012-10-22 07:05:34 UTC) #15
shanemhansen
dsymonds, I just have one question about ReadAll(tr) vs ReadAll(r). https://codereview.appspot.com/6700047/diff/18001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/18001/src/pkg/archive/tar/reader.go#newcode71 ...
9 years, 10 months ago (2012-10-23 02:54:13 UTC) #16
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-10-23 03:16:09 UTC) #17
dsymonds
Sorry again for the delay. I think I've got a handle on this; the rest ...
9 years, 9 months ago (2012-10-31 02:44:37 UTC) #18
shanemhansen
https://codereview.appspot.com/6700047/diff/18001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/18001/src/pkg/archive/tar/reader.go#newcode201 src/pkg/archive/tar/reader.go:201: func parsePAX(tr io.Reader) (map[string]string, error) { Ok, that makes ...
9 years, 9 months ago (2012-10-31 04:26:30 UTC) #19
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-10-31 04:33:22 UTC) #20
dsymonds
https://codereview.appspot.com/6700047/diff/29004/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/29004/src/pkg/archive/tar/writer.go#newcode184 src/pkg/archive/tar/writer.go:184: extendedHdr := new(Header) extendedHdr -> ext https://codereview.appspot.com/6700047/diff/29004/src/pkg/archive/tar/writer.go#newcode189 src/pkg/archive/tar/writer.go:189: // ...
9 years, 9 months ago (2012-10-31 12:16:25 UTC) #21
shanemhansen
https://codereview.appspot.com/6700047/diff/29004/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/29004/src/pkg/archive/tar/writer.go#newcode202 src/pkg/archive/tar/writer.go:202: fmt.Fprintf(&buf, "%d%s", size, msg) The pax standard is weird ...
9 years, 9 months ago (2012-11-01 02:40:57 UTC) #22
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-11-01 02:42:21 UTC) #23
dsymonds
On Thu, Nov 1, 2012 at 1:40 PM, <shanemhansen@gmail.com> wrote: > The pax standard is ...
9 years, 9 months ago (2012-11-01 02:44:31 UTC) #24
dsymonds
https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go#newcode198 src/pkg/archive/tar/writer.go:198: msg := fmt.Sprintf(" path=%s\n", hdr.Name) pull this block into ...
9 years, 9 months ago (2012-11-01 02:51:37 UTC) #25
shanemhansen
It was produced by tar (GNU tar) 1.26 Here's a script to reproduce the behaviour. ...
9 years, 9 months ago (2012-11-01 03:16:02 UTC) #26
dsymonds
Okay, just pull it out into a function as I suggest and carefully test it.
9 years, 9 months ago (2012-11-01 03:17:02 UTC) #27
chressie1
https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go#newcode192 src/pkg/archive/tar/writer.go:192: dir, file := filepath.Split(hdr.Name) i think the delimiter in ...
9 years, 9 months ago (2012-11-05 15:51:08 UTC) #28
chressie1
https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go#newcode193 src/pkg/archive/tar/writer.go:193: ext.Name = filepath.Join(dir, another issue i can see is ...
9 years, 9 months ago (2012-11-05 17:44:47 UTC) #29
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-11-07 00:53:53 UTC) #30
shanemhansen
https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go#newcode192 src/pkg/archive/tar/writer.go:192: dir, file := filepath.Split(hdr.Name) According to my reading of ...
9 years, 9 months ago (2012-11-07 00:59:48 UTC) #31
dsymonds
https://codereview.appspot.com/6700047/diff/30004/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/30004/src/pkg/archive/tar/writer.go#newcode198 src/pkg/archive/tar/writer.go:198: fmt.Fprint(&buf, paxHeader(fmt.Sprintf("path=%s", hdr.Name))) no need for fmt.Sprintf just to ...
9 years, 9 months ago (2012-11-07 01:02:25 UTC) #32
chressie1
https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/34007/src/pkg/archive/tar/writer.go#newcode192 src/pkg/archive/tar/writer.go:192: dir, file := filepath.Split(hdr.Name) On 2012/11/07 00:59:48, shanemhansen wrote: ...
9 years, 9 months ago (2012-11-07 06:42:51 UTC) #33
dsymonds
Hi Shane, Any progress on this? It seems like this CL is close to being ...
9 years, 8 months ago (2012-12-04 00:00:03 UTC) #34
shanemhansen
On 2012/12/04 00:00:03, dsymonds wrote: > Hi Shane, > > Any progress on this? It ...
9 years, 8 months ago (2012-12-04 00:01:22 UTC) #35
dsymonds
ping. Time for another progress report? This CL is pretty close to being done.
9 years, 8 months ago (2012-12-15 11:42:29 UTC) #36
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2013-01-09 01:46:56 UTC) #37
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2013-01-09 01:52:10 UTC) #38
dsymonds
This looks pretty close to me. https://codereview.appspot.com/6700047/diff/51001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/51001/src/pkg/archive/tar/reader.go#newcode248 src/pkg/archive/tar/reader.go:248: // Check for ...
9 years, 7 months ago (2013-01-09 02:13:17 UTC) #39
shanemhansen
Hello golang-dev@googlegroups.com, dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2013-01-09 02:40:15 UTC) #40
shanemhansen
https://codereview.appspot.com/6700047/diff/51001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/51001/src/pkg/archive/tar/reader.go#newcode248 src/pkg/archive/tar/reader.go:248: // Check for binary format first. On 2013/01/09 02:13:17, ...
9 years, 7 months ago (2013-01-09 02:40:27 UTC) #41
dsymonds
LGTM This looks good to me. Given the subtlety and complexity of this CL I'll ...
9 years, 7 months ago (2013-01-09 02:42:34 UTC) #42
shanemhansen
On 2013/01/09 02:42:34, dsymonds wrote: > LGTM > > This looks good to me. > ...
9 years, 7 months ago (2013-01-09 02:45:42 UTC) #43
rsc
FYI https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/reader.go#newcode179 src/pkg/archive/tar/reader.go:179: nano_buf := string(buf[pos+1:]) nanoBuf https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/reader.go#newcode213 src/pkg/archive/tar/reader.go:213: if sp ...
9 years, 7 months ago (2013-01-09 19:43:49 UTC) #44
shanemhansen
https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/reader.go#newcode179 src/pkg/archive/tar/reader.go:179: nano_buf := string(buf[pos+1:]) On 2013/01/09 19:43:49, rsc wrote: > ...
9 years, 7 months ago (2013-01-11 01:52:42 UTC) #45
rsc
Sorry for the late reply. Using PAX is fine as long as it's restricted to ...
9 years, 6 months ago (2013-01-23 04:47:56 UTC) #46
chressie1
On 2013/01/23 04:47:56, rsc wrote: > Sorry for the late reply. Using PAX is fine ...
9 years, 6 months ago (2013-01-30 13:04:24 UTC) #47
chressie1
On 2013/01/30 13:04:24, chressie1 wrote: > i think this is very close to be finished. ...
9 years, 6 months ago (2013-01-30 13:12:54 UTC) #48
shanemhansen
Hi Chressie1, Sorry I've been so busy, but I haven't gone mia. I'd be happy ...
9 years, 6 months ago (2013-01-31 03:00:18 UTC) #49
chressie1
On 2013/01/31 03:00:18, shanemhansen wrote: > Hi Chressie1, > Sorry I've been so busy, but ...
9 years, 6 months ago (2013-01-31 11:24:06 UTC) #50
dsymonds
I think we should just get Shane's CL finished off (I believe it's very close), ...
9 years, 6 months ago (2013-01-31 22:56:14 UTC) #51
shanemhansen
Sounds good to me. I'll work on adding support for ustar long names. Thanks for ...
9 years, 6 months ago (2013-02-06 03:48:16 UTC) #52
chressie1
sorry, i'm afraid, i wasn't clear in the first place. the merge CL https://codereview.appspot.com/7229066 is ...
9 years, 6 months ago (2013-02-06 07:18:33 UTC) #53
chressie1
one last thing.. https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/writer_test.go File src/pkg/archive/tar/writer_test.go (right): https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/writer_test.go#newcode225 src/pkg/archive/tar/writer_test.go:225: func aTestPAXHeader(t *testing.T) { this test ...
9 years, 6 months ago (2013-02-06 07:22:17 UTC) #54
shanemhansen
Good find. This would be done last night except I switched to an OSX system ...
9 years, 6 months ago (2013-02-06 17:14:38 UTC) #55
shanemhansen
Hello dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2013-02-07 03:35:37 UTC) #56
shanemhansen
Hello dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2013-02-07 03:36:39 UTC) #57
shanemhansen
Sorry for all the spam. I had a little trouble doing a hg file XXXX ...
9 years, 6 months ago (2013-02-07 03:57:23 UTC) #58
dfc
You can use hg upload NNNN to avoid sending mail until you are happy with ...
9 years, 6 months ago (2013-02-07 04:02:22 UTC) #59
dsymonds
https://codereview.appspot.com/6700047/diff/65002/src/pkg/archive/tar/common.go File src/pkg/archive/tar/common.go (right): https://codereview.appspot.com/6700047/diff/65002/src/pkg/archive/tar/common.go#newcode62 src/pkg/archive/tar/common.go:62: FileNameSize = 100 these don't need to be exported. ...
9 years, 6 months ago (2013-02-07 04:16:27 UTC) #60
shanemhansen
https://codereview.appspot.com/6700047/diff/65002/src/pkg/archive/tar/common.go File src/pkg/archive/tar/common.go (right): https://codereview.appspot.com/6700047/diff/65002/src/pkg/archive/tar/common.go#newcode62 src/pkg/archive/tar/common.go:62: FileNameSize = 100 On 2013/02/07 04:16:27, dsymonds wrote: > ...
9 years, 6 months ago (2013-02-07 04:35:43 UTC) #61
shanemhansen
Hello dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2013-02-07 04:36:49 UTC) #62
dsymonds
LGTM patchset #20 now looks fine to me. Let's see what other people say. https://codereview.appspot.com/6700047/diff/69010/src/pkg/archive/tar/reader_test.go ...
9 years, 6 months ago (2013-02-07 04:45:29 UTC) #63
shanemhansen
https://codereview.appspot.com/6700047/diff/69010/src/pkg/archive/tar/reader_test.go File src/pkg/archive/tar/reader_test.go (right): https://codereview.appspot.com/6700047/diff/69010/src/pkg/archive/tar/reader_test.go#newcode308 src/pkg/archive/tar/reader_test.go:308: t.Errorf("Couldn't parse correctly formatted headers %v", err) On 2013/02/07 ...
9 years, 6 months ago (2013-02-07 04:48:21 UTC) #64
chressie1
https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go#newcode202 src/pkg/archive/tar/writer.go:202: func (tw *Writer) splitUSTARLongName(name string) (prefix, suffix string, err ...
9 years, 6 months ago (2013-02-07 08:03:39 UTC) #65
shanemhansen
https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go#newcode202 src/pkg/archive/tar/writer.go:202: func (tw *Writer) splitUSTARLongName(name string) (prefix, suffix string, err ...
9 years, 6 months ago (2013-02-07 19:50:27 UTC) #66
chressie1
https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go#newcode210 src/pkg/archive/tar/writer.go:210: nlen := length - i - 1 On 2013/02/07 ...
9 years, 6 months ago (2013-02-08 07:32:10 UTC) #67
shanemhansen
https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go File src/pkg/archive/tar/writer.go (right): https://codereview.appspot.com/6700047/diff/71008/src/pkg/archive/tar/writer.go#newcode210 src/pkg/archive/tar/writer.go:210: nlen := length - i - 1 On 2013/02/08 ...
9 years, 6 months ago (2013-02-08 07:35:34 UTC) #68
shanemhansen
Hello dsymonds@golang.org, dave@cheney.net, rogpeppe@gmail.com, remyoudompheng@gmail.com, chressie@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2013-02-08 07:35:34 UTC) #69
chressie1
LGTM thanks!
9 years, 6 months ago (2013-02-08 07:39:14 UTC) #70
dsymonds
LGTM Unless anyone pounces with yet more changes to make, I'll submit this later today. ...
9 years, 6 months ago (2013-02-10 21:45:46 UTC) #71
dfc
Thanks Shane, I think all the blood has been squeezed from this stone.
9 years, 6 months ago (2013-02-11 00:32:43 UTC) #72
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=7ad748c63169 *** archive/tar: read/write extended pax/gnu tar archives Support reading pax archives ...
9 years, 6 months ago (2013-02-11 00:36:48 UTC) #73
shanemhansen
9 years, 6 months ago (2013-02-11 18:13:10 UTC) #74
Yay. Thanks for all the helpful feedback along the way, it was much
appreciated.

--Shane

On Sun, Feb 10, 2013 at 5:36 PM, <dsymonds@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=7ad748c63169<https://code.goog...
>
> archive/tar: read/write extended pax/gnu tar archives
>
> Support reading pax archives and applying extended attributes
> like long names, subsecond mtime resolutions, etc. Default to
> writing pax archives for long file and link names.
> Support reading gnu archives using the ././@LongLink extended
> header for file name and link target.
>
> Fixes issue 3300
>
> R=dsymonds, dave, rogpeppe, remyoudompheng, chressie, rsc
> CC=golang-dev
>
https://codereview.appspot.**com/6700047<https://codereview.appspot.com/6700047>
>
> Committer: David Symonds <dsymonds@golang.org>
>
>
>
https://codereview.appspot.**com/6700047/<https://codereview.appspot.com/6700...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b