Service view footer design

Service view footer design

The service view footer should match visual design document.
(https://docs.google.com/a/canonical.com/file/d/0B6l8lFdCRvtqS19SYWQ2MzU3cFU/edit)

https://code.launchpad.net/~tveronezi/juju-gui/service-view-footer/+merge/129696

(do not edit description out of merge proposal)

[thiago, 2012-10-15 15:33:14]

Please take a look.

[matthew.scott, 2012-10-15 16:49:51]

Trainee review by Matthew.  Looks good, with some minors.

https://codereview.appspot.com/6698043/diff/1/app/templates/service-footer.pa...
File app/templates/service-footer.partial (right):

https://codereview.appspot.com/6698043/diff/1/app/templates/service-footer.pa...
app/templates/service-footer.partial:4: <img
src="/juju-ui/assets/images/destroy_icon.png">Destroy
Empty tags should have a closing slash within. Ditto below.

<img ... />

https://codereview.appspot.com/6698043/diff/1/app/templates/service.handlebars
File app/templates/service.handlebars (right):

https://codereview.appspot.com/6698043/diff/1/app/templates/service.handlebar...
app/templates/service.handlebars:13: <img
src="/juju-ui/assets/images/destroy_icon.png">Destroy
See note about empty tags.  Ditto below.

https://codereview.appspot.com/6698043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6698043/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:947: a:link {
These can be collapsed for readability:

a:link, a:visited, a:active, a:hover {...

[thiago, 2012-10-15 18:38:01]

https://codereview.appspot.com/6698043/diff/1/app/templates/service-footer.pa...
File app/templates/service-footer.partial (right):

https://codereview.appspot.com/6698043/diff/1/app/templates/service-footer.pa...
app/templates/service-footer.partial:4: <img
src="/juju-ui/assets/images/destroy_icon.png">Destroy
On 2012/10/15 16:49:51, matthew.scott wrote:
> Empty tags should have a closing slash within. Ditto below.
> 
> <img ... />

afaik, img does not have closing tag. But I will do it anyway. I won't hurt. :)

https://codereview.appspot.com/6698043/diff/1/app/templates/service.handlebars
File app/templates/service.handlebars (right):

https://codereview.appspot.com/6698043/diff/1/app/templates/service.handlebar...
app/templates/service.handlebars:13: <img
src="/juju-ui/assets/images/destroy_icon.png">Destroy
On 2012/10/15 16:49:51, matthew.scott wrote:
> See note about empty tags.  Ditto below.

Done.

https://codereview.appspot.com/6698043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6698043/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:947: a:link {
On 2012/10/15 16:49:51, matthew.scott wrote:
> These can be collapsed for readability:
> 
> a:link, a:visited, a:active, a:hover {...

Done.

[thiago, 2012-10-15 18:43:33]

Please take a look.

[gary.poster, 2012-10-15 20:59:51]

Looks good.  Thanks Thiago.  Approved.

Gary

https://codereview.appspot.com/6698043/diff/8001/app/templates/service-footer...
File app/templates/service-footer.partial (right):

https://codereview.appspot.com/6698043/diff/8001/app/templates/service-footer...
app/templates/service-footer.partial:6: <img class="divider"
src="/juju-ui/assets/images/bottom_bar_big_div.png" />
/me mutters to himself that he wishes we would do these with nested divs and
borders instead.  Meanwhile, this is fine.

https://codereview.appspot.com/6698043/diff/8001/app/templates/service.handle...
File app/templates/service.handlebars (right):

https://codereview.appspot.com/6698043/diff/8001/app/templates/service.handle...
app/templates/service.handlebars:12: <a id="destroy-service" data-toggle="modal"
href="#destroy-service-modal">
I really wish there were some user feedback here, for hover especially.  We have
nothing from the visual design for this though, so this is not your issue.

[thiago, 2012-10-17 18:58:13]

*** Submitted:

Service view footer design

The service view footer should match visual design document.
(https://docs.google.com/a/canonical.com/file/d/0B6l8lFdCRvtqS19SYWQ2MzU3cFU/edit)

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/6698043