Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 66920043: environs/config: fix optional values/defaults

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by axw
Modified:
10 years, 2 months ago
Reviewers:
mp+207609, wallyworld
Visibility:
Public.

Description

environs/config: fix optional values/defaults We have config values which are optional for backwards compatibility. In some cases these should take on a different value to what the default for a new config is. The way the defaults map is currently constructed means that the backwards-compatibility values always overwrite the defaults. https://code.launchpad.net/~axwalk/juju-core/config-defaults/+merge/207609 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config/config.go View 2 chunks +6 lines, -1 line 0 comments Download
M environs/config/config_test.go View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
10 years, 2 months ago (2014-02-21 10:10:26 UTC) #1
wallyworld
10 years, 2 months ago (2014-02-24 02:40:27 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b