Issue 668041: Remove duplicate Bypass enum

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 668041: Remove duplicate Bypass enum

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by zhoresh

Modified:
14 years, 1 month ago

Reviewers:
johnfargo, Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

As part of the rewriter refactoring two Bypass enums exists, and for each there is a static function which uses it. This cause a problem since most classes used the old enum while TrustedTemplateTagHandler used the new one. To prevent confusion, the old enum is removed. I scan the rest of the "old" classes and didn't find other similar cases.

Patch Set 1 #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+76 lines, -72 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java	View	6 chunks	+12 lines, -7 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriter.java	View	5 chunks	+10 lines, -34 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java	View	3 chunks	+7 lines, -7 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/XmlTemplateLibrary.java	View	3 chunks	+6 lines, -6 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/FlashTagHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactoryTest.java	View	1 chunk	+19 lines, -0 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriterTest.java	View	4 chunks	+11 lines, -9 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java	View	3 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul Lindner

lgtm, patch applied. Please do create a jira issue with the attached patch so you ...

14 years, 1 month ago (2010-03-20 08:11:32 UTC) #2

zhoresh

14 years, 1 month ago (2010-03-21 02:25:56 UTC) #3

On 2010/03/20 08:11:32, Paul Lindner wrote:
> lgtm, patch applied.
> 
> Please do create a jira issue with the attached patch so you can grant apache
> the license for the change.
> 
> Thanks!

Thanks! I created bug report for it: 
https://issues.apache.org/jira/browse/SHINDIG-1308

Expand All Messages | Collapse All Messages