Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1245)

Issue 66720043: code review 66720043: ogle/gosym: sync with tip debug/gosym in the standard l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by nigeltao
Modified:
7 years, 9 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/gosym: sync with tip debug/gosym in the standard library. In particular, pick up changeset: 19158:737767dd81fd user: Russ Cox <rsc@golang.org> date: Tue Feb 18 23:41:15 2014 -0500 summary: cmd/ld: remove Plan 9 symbol table (code review 65740045)

Patch Set 1 #

Patch Set 2 : diff -r ac1c51d47094 https://code.google.com/p/ogle #

Patch Set 3 : diff -r ac1c51d47094 https://code.google.com/p/ogle #

Patch Set 4 : diff -r a41fee5ddf57 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M gosym/pclntab.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
M gosym/symtab.go View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 9 months ago (2014-02-21 00:11:13 UTC) #1
r
LGTM
7 years, 9 months ago (2014-02-21 00:27:53 UTC) #2
nigeltao
7 years, 9 months ago (2014-02-21 04:25:39 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=549f344bf0b2 ***

ogle/gosym: sync with tip debug/gosym in the standard library.

In particular, pick up
changeset:   19158:737767dd81fd
user:        Russ Cox <rsc@golang.org>
date:        Tue Feb 18 23:41:15 2014 -0500
summary:     cmd/ld: remove Plan 9 symbol table
(code review 65740045)

LGTM=r
R=r
https://codereview.appspot.com/66720043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b