Issue 66720043: code review 66720043: ogle/gosym: sync with tip debug/gosym in the standard l...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66720043: code review 66720043: ogle/gosym: sync with tip debug/gosym in the standard l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by nigeltao

Modified:
10 years, 2 months ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/gosym: sync with tip debug/gosym in the standard library. In particular, pick up changeset: 19158:737767dd81fd user: Russ Cox <rsc@golang.org> date: Tue Feb 18 23:41:15 2014 -0500 summary: cmd/ld: remove Plan 9 symbol table (code review 65740045)

Patch Set 1 #

Patch Set 2 : diff -r ac1c51d47094 https://code.google.com/p/ogle #

Patch Set 3 : diff -r ac1c51d47094 https://code.google.com/p/ogle #

Patch Set 4 : diff -r a41fee5ddf57 https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	gosym/pclntab.go	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
	M	gosym/symtab.go	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-21 00:11:13 UTC) #1

nigeltao

10 years, 2 months ago (2014-02-21 04:25:39 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=549f344bf0b2 ***

ogle/gosym: sync with tip debug/gosym in the standard library.

In particular, pick up
changeset:   19158:737767dd81fd
user:        Russ Cox <rsc@golang.org>
date:        Tue Feb 18 23:41:15 2014 -0500
summary:     cmd/ld: remove Plan 9 symbol table
(code review 65740045)

LGTM=r
R=r
https://codereview.appspot.com/66720043

Expand All Messages | Collapse All Messages