Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 6670043: i#948: set MAP_IMPORTED_CONFIG_{RELWITHDEBINFO,RELMINSIZE}

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by Derek
Modified:
11 years, 6 months ago
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Reviewer: rnk@google.com i#948: set MAP_IMPORTED_CONFIG_{RELWITHDEBINFO,RELMINSIZE} fixes issue 948 Set MAP_IMPORTED_CONFIG_{RELWITHDEBINFO,RELMINSIZE} for every exported target so that an including project can use those build types. CMake did not make this easy: it took raw appending to the file and a separate append on install.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
M CMakeLists.txt View 2 chunks +27 lines, -5 lines 0 comments Download
M core/CMakeLists.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M ext/CMakeLists.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M ext/drcontainers/CMakeLists.txt View 1 chunk +1 line, -3 lines 0 comments Download
M ext/drmgr/CMakeLists.txt View 1 chunk +1 line, -3 lines 0 comments Download
M ext/drsyms/CMakeLists.txt View 1 chunk +1 line, -2 lines 0 comments Download
M ext/drutil/CMakeLists.txt View 1 chunk +1 line, -2 lines 0 comments Download
M ext/drwrap/CMakeLists.txt View 1 chunk +1 line, -2 lines 0 comments Download
M libutil/CMakeLists.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
Derek
11 years, 6 months ago (2012-10-12 19:41:25 UTC) #1
Reid Kleckner (google)
11 years, 6 months ago (2012-10-15 14:03:22 UTC) #2
LGTM

Weird.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b