Issue 66650043: Add test test_communicate_after_exit(�)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66650043: Add test test_communicate_after_exit(�)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by haypo_gmail

Modified:
10 years, 2 months ago

Reviewers:
GvR

Visibility:
Public.

More Reviews

Description

Add test test_communicate_after_exit(�)

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
	M	tests/test_subprocess.py	View		3 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

GvR

What do you think of waiting to commit this until after 3.4? The actual code ...

10 years, 2 months ago (2014-02-20 19:56:35 UTC) #1

haypo_gmail

10 years, 2 months ago (2014-02-20 20:57:21 UTC) #2

On 2014/02/20 19:56:35, GvR wrote:
> What do you think of waiting to commit this until after 3.4? The actual code
is
> correct (assuming the test passes :-), and the test is complex enough that I'm
a
> little concerned.

As you want.

Expand All Messages | Collapse All Messages