Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15779)

Issue 6656051: uniter: test improvements

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by fwereade
Modified:
11 years, 6 months ago
Reviewers:
mp+129391
Visibility:
Public.

Description

uniter: test improvements * on unit death, lack of hooks is now only verified *after* the uniter has stopped (previously, it would have been possible to fail to detect an unwanted hook. * some consolidation of repeated code * direct verification of the correct functioning of config-get, which was previously lacking and most importantly * by actually setting a Service from which the config can be got, cause config-get to function correctly again https://code.launchpad.net/~fwereade/juju-core/trivial-fix-config-get-context/+merge/129391 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : uniter: test improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -24 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/uniter.go View 1 chunk +1 line, -0 lines 0 comments Download
M worker/uniter/uniter_test.go View 10 chunks +50 lines, -24 lines 0 comments Download

Messages

Total messages: 3
fwereade
Please take a look.
11 years, 6 months ago (2012-10-12 11:29:11 UTC) #1
rog
On 2012/10/12 11:29:11, fwereade wrote: > Please take a look. LGTM
11 years, 6 months ago (2012-10-12 11:44:18 UTC) #2
fwereade
11 years, 6 months ago (2012-10-12 11:49:03 UTC) #3
*** Submitted:

uniter: test improvements

* on unit death, lack of hooks is now only verified *after* the uniter has
  stopped (previously, it would have been possible to fail to detect an
  unwanted hook.
* some consolidation of repeated code
* direct verification of the correct functioning of config-get, which was
  previously lacking

and most importantly

* by actually setting a Service from which the config can be got, cause
  config-get to function correctly again

R=rog
CC=
https://codereview.appspot.com/6656051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b