Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 6655045: code review 6655045: cmd/5l: reorder some struct fields to reduce memory con... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by minux1
Modified:
9 years, 10 months ago
Reviewers:
remyoudompheng
CC:
golang-dev, r, dfc
Visibility:
Public.

Description

cmd/5l: reorder some struct fields to reduce memory consumption Valgrind Massif result when linking godoc: On amd64: old new -/+ mem_heap_B 185844612 175358047 -5.7% mem_heap_extra_B 773404 773137 -0.0% On 386/ARM: old new -/+ mem_heap_B 141775701 131289941 -7.4% mem_heap_extra_B 737011 736955 -0.0%

Patch Set 1 #

Patch Set 2 : diff -r caf30a0fbd77 https://code.google.com/p/go/ #

Patch Set 3 : diff -r caf30a0fbd77 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 43d23086b2ad https://code.google.com/p/go/ #

Patch Set 5 : diff -r 43d23086b2ad https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/cmd/5l/l.h View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 10 months ago (2012-10-11 16:22:09 UTC) #1
minux1
Note: the same field reorder isn't applicable to cmd/8l or cmd/6l.
9 years, 10 months ago (2012-10-11 18:43:31 UTC) #2
r
LGTM
9 years, 10 months ago (2012-10-11 20:52:12 UTC) #3
dfc
On 2012/10/11 20:52:12, r wrote: > LGTM LGTM. Are there similar savings inside 5g ?
9 years, 10 months ago (2012-10-12 02:41:02 UTC) #4
minux1
*** Submitted as http://code.google.com/p/go/source/detail?r=1baa80f7f4a4 *** cmd/5l: reorder some struct fields to reduce memory consumption Valgrind ...
9 years, 10 months ago (2012-10-12 05:39:33 UTC) #5
minux1
On Fri, Oct 12, 2012 at 10:41 AM, <dave@cheney.net> wrote: > Are there similar savings ...
9 years, 10 months ago (2012-10-12 06:01:16 UTC) #6
minux1
On Fri, Oct 12, 2012 at 2:00 PM, minux <minux.ma@gmail.com> wrote: > > On Fri, ...
9 years, 10 months ago (2012-10-12 06:32:19 UTC) #7
remyoudompheng
On 2012/10/12 minux <minux.ma@gmail.com> wrote: > The same reordering is applicable to gc, but i ...
9 years, 10 months ago (2012-10-12 06:41:05 UTC) #8
minux1
On Fri, Oct 12, 2012 at 2:41 PM, Rémy Oudompheng <remyoudompheng@gmail.com>wrote: > As far as ...
9 years, 10 months ago (2012-10-12 07:07:23 UTC) #9
dfc
5.3Gb to compile! That is getting into Firefox territory. http://www.phoronix.com/scan.php?page=news_item&px=MTA3MTQ On Fri, Oct 12, 2012 ...
9 years, 10 months ago (2012-10-12 07:14:04 UTC) #10
minux1
9 years, 10 months ago (2012-10-12 07:51:20 UTC) #11
On Fri, Oct 12, 2012 at 3:14 PM, Dave Cheney <dave@cheney.net> wrote:

> 5.3Gb to compile! That is getting into Firefox territory.
> http://www.phoronix.com/scan.php?page=news_item&px=MTA3MTQ

That's the very reason that test is not enabled by default, or
all the builders will blow up. :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b