cmd/jujud: make agents change passwords ASAP

cmd/jujud: make agents change passwords ASAP



https://code.launchpad.net/~rogpeppe/juju-core/122-jujud-change-passwords/+merge/129210

(do not edit description out of merge proposal)

[niemeyer, 2012-10-11 14:46:14]

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go
File cmd/jujud/agent.go (right):

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go#newcode162
cmd/jujud/agent.go:162: func openState(entityName string, conf *AgentConf) (_
*state.State, newPassword string, err error) {
s/_/st/

Probably s/newPassword/password/ also. That's how it was named elsewhere.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go#newcode164
cmd/jujud/agent.go:164: pwfile := filepath.Join(secretDir, "password")
This can be within the agent directory itself.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go#newcode191
cmd/jujud/agent.go:191: if st != nil && err != nil {
There will only be two error cases below. It's cheaper and more clear to have
st.Close inlined.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent_test.go
File cmd/jujud/agent_test.go (right):

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent_test.go#newcode257
cmd/jujud/agent_test.go:257: func testAgentPasswordChanging(s
*testing.JujuConnSuite, c *C, ent entity, dataDir string, newAgent
func(initialPassword string) runner) {
It'd be nice to try again with the old password once the password changes, and
ensure the expected error happens. As it is, if we disable auth entirely,
everything will probably work.

[rog, 2012-10-11 15:21:39]

Please take a look.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go
File cmd/jujud/agent.go (right):

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go#newcode162
cmd/jujud/agent.go:162: func openState(entityName string, conf *AgentConf) (_
*state.State, newPassword string, err error) {
On 2012/10/11 14:46:14, niemeyer wrote:
> s/_/st/
> 
> Probably s/newPassword/password/ also. That's how it was named elsewhere.

Done.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go#newcode164
cmd/jujud/agent.go:164: pwfile := filepath.Join(secretDir, "password")
On 2012/10/11 14:46:14, niemeyer wrote:
> This can be within the agent directory itself.

Done.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent.go#newcode191
cmd/jujud/agent.go:191: if st != nil && err != nil {
On 2012/10/11 14:46:14, niemeyer wrote:
> There will only be two error cases below. It's cheaper and more clear to have
> st.Close inlined.

Done.

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent_test.go
File cmd/jujud/agent_test.go (right):

https://codereview.appspot.com/6655044/diff/1/cmd/jujud/agent_test.go#newcode257
cmd/jujud/agent_test.go:257: func testAgentPasswordChanging(s
*testing.JujuConnSuite, c *C, ent entity, dataDir string, newAgent
func(initialPassword string) runner) {
On 2012/10/11 14:46:14, niemeyer wrote:
> It'd be nice to try again with the old password once the password changes, and
> ensure the expected error happens. As it is, if we disable auth entirely,
> everything will probably work.

Done.

[niemeyer, 2012-10-11 15:39:38]

LGTM

[rog, 2012-10-11 15:40:59]

*** Submitted:

cmd/jujud: make agents change passwords ASAP

R=niemeyer
CC=
https://codereview.appspot.com/6655044