Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2843)

Issue 6655043: environs: add AgentDir function

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rog
Modified:
11 years, 6 months ago
Reviewers:
mp+129174
Visibility:
Public.

Description

environs: add AgentDir function This will be used by the machine agent to store its password in. I realise that the agent directory structure is expecting an overhaul, but this should do as a place holder in the meantime. We also create the machine agent's directory, and remove a couple of spurious sudos in passing. https://code.launchpad.net/~rogpeppe/juju-core/120-agent-dir/+merge/129174 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add AgentDir function #

Patch Set 3 : environs: add AgentDir function #

Patch Set 4 : environs: add AgentDir function #

Patch Set 5 : environs: add AgentDir function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -31 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/agent.go View 1 2 3 4 2 chunks +53 lines, -10 lines 0 comments Download
M cmd/jujud/agent_test.go View 1 2 3 4 2 chunks +87 lines, -2 lines 0 comments Download
M cmd/jujud/machine.go View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M cmd/jujud/machine_test.go View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M cmd/jujud/unit.go View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M cmd/jujud/unit_test.go View 1 2 3 4 2 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 6 months ago (2012-10-11 12:44:28 UTC) #1
niemeyer
LGTM
11 years, 6 months ago (2012-10-11 12:47:42 UTC) #2
rog
11 years, 6 months ago (2012-10-11 13:01:50 UTC) #3
*** Submitted:

environs: add AgentDir function

This will be used by the machine agent to
store its password in. I realise that the
agent directory structure is expecting an overhaul,
but this should do as a place holder in the
meantime.

We also create the machine agent's directory,
and remove a couple of spurious sudos in passing.

R=niemeyer
CC=
https://codereview.appspot.com/6655043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b