Issue 66540043: Log context after the exception in default_exception_handler()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66540043: Log context after the exception in default_exception_handler()

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by haypo_gmail

Modified:
10 years, 2 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Log context after the exception in default_exception_handler()

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -65 lines)			Patch
M	asyncio/base_events.py	View	2 chunks	+8 lines, -5 lines	1 comment	Download
M	asyncio/futures.py	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	asyncio/test_utils.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_base_events.py	View	6 chunks	+41 lines, -27 lines	0 comments	Download
M	tests/test_selector_events.py	View	2 chunks	+24 lines, -12 lines	0 comments	Download
M	tests/test_unix_events.py	View	2 chunks	+26 lines, -15 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

yselivanov

10 years, 2 months ago (2014-02-20 16:00:04 UTC) #1

Victor, to be honest, I don't think this is an issue.

https://codereview.appspot.com/66540043/diff/1/asyncio/base_events.py
File asyncio/base_events.py (right):

https://codereview.appspot.com/66540043/diff/1/asyncio/base_events.py#newcode677
asyncio/base_events.py:677: logger.error('\n'.join(log_lines))
Absolutely no!

Exception object *must* go to the logger routines. Lots of code relies on it,
just one example: error monitoring services like airbrake or newrelic install
their own LoggingHandlers to intercept exceptions and report them. They format
tracebacks and exception chains themselves.

Expand All Messages | Collapse All Messages