Quicken env. redraw after relation add and remove

Quicken env. redraw after relation add and remove

Do not wait for delta, but update the db and redraw the environment
on RPC results, on both relation addition and removal.
Also, fix a notification bug on relation removal.

https://code.launchpad.net/~teknico/juju-ui/quicken-new-relation-draw/+merge/129449

(do not edit description out of merge proposal)

[teknico, 2012-10-12 14:54:31]

Please take a look.

[hazmat, 2012-10-12 19:58:50]

looks good

https://codereview.appspot.com/6652055/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6652055/diff/1/app/views/environment.js#newcod...
app/views/environment.js:1294: type: endpoints[0][1].name,
not quite type != name, name has naught to do with type, its just the service's
name for that particular relation regardless of type. ie. wordpress calls type:
mysql relation name: db.

please also store 'scope':result.scope  so we can determine if the relation is a
subordinate or not.

[hazmat, 2012-10-12 20:11:18]

I just noticed/realized we're drawing the relation name everywhere.. instead of
the interface. it does look much better, but its a bit arbitrary.

Ideally we store continue to display this, but we store it as a display_name on
the rel, we should still capture the actual interface type of the rel correctly.

[hazmat, 2012-10-12 20:48:59]

the relation display_name can be either pushed to another branch/card or done
here but the other minors should be worked on.

https://codereview.appspot.com/6652055/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6652055/diff/1/app/views/environment.js#newcod...
app/views/environment.js:931: env.remove_relation(
This call needs to have the qualified endpoints to be done correctly, ie. not
just service name but the 

service_name:endpoint_name for each side, else you can run into ambiguity errors
removing a  relation.. like for example between mediawiki and mysql.

[teknico, 2012-10-15 14:42:29]

Please take a look.

[teknico, 2012-10-15 14:44:24]

hazmat wrote [a fair number of comments :-) ]:
> [snip]

We believe we addressed all the points you raised (and then some ;-) ). Please
check and let us know, thanks.

[hazmat, 2012-10-15 18:19:47]

looks good, thanks for the changes.

https://codereview.appspot.com/6652055/diff/7001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6652055/diff/7001/app/views/environment.js#new...
app/views/environment.js:857: if (bpair.display_name === undefined) {
aha i was wondering where this was being done.