Issue 6650043: uniter: filter now sends relations events

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6650043: uniter: filter now sends relations events

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by fwereade

Modified:
11 years, 6 months ago

Reviewers:
mp+129116

Visibility:
Public.

Description

uniter: filter now sends relations events https://code.launchpad.net/~fwereade/juju-core/uniter-filter-relations/+merge/129116 Requires: https://code.launchpad.net/~fwereade/juju-core/uniter-rework-config-changed/+merge/129066 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : uniter: filter now sends relations events #

Total comments: 2

Patch Set 3 : uniter: filter now sends relations events #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -18 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/filter.go	View	1 2	8 chunks	+59 lines, -18 lines	0 comments	Download
M	worker/uniter/filter_test.go	View	1 2	2 chunks	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Pleasantly straightforward! LGTM https://codereview.appspot.com/6650043/diff/2002/worker/uniter/filter.go File worker/uniter/filter.go (right): https://codereview.appspot.com/6650043/diff/2002/worker/uniter/filter.go#newcode54 worker/uniter/filter.go:54: relations map[int]struct{} As we talked, this ...

11 years, 6 months ago (2012-10-12 00:24:28 UTC) #3

fwereade

11 years, 6 months ago (2012-10-12 07:26:08 UTC) #4

*** Submitted:

uniter: filter now sends relations events

R=niemeyer
CC=
https://codereview.appspot.com/6650043

https://codereview.appspot.com/6650043/diff/2002/worker/uniter/filter.go
File worker/uniter/filter.go (right):

https://codereview.appspot.com/6650043/diff/2002/worker/uniter/filter.go#newc...
worker/uniter/filter.go:54: relations        map[int]struct{}
On 2012/10/12 00:24:28, niemeyer wrote:
> As we talked, this would be better both in terms of the interface we see and
use
> and in terms of performance (which is irrelevant in this case) as a []int.

Done.

Expand All Messages | Collapse All Messages