Issue 66470043: code review 66470043: net/http: remove tmp file created in TestMultipartReade...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66470043: code review 66470043: net/http: remove tmp file created in TestMultipartReade... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by brainman

Modified:
11 years, 4 months ago

Reviewers:
minux1

CC:
golang-codereviews, minux1

Visibility:
Public.

Description

net/http: remove tmp file created in TestMultipartReaderOrder

Patch Set 1 #

Patch Set 2 : diff -r 1c88090bebc6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1c88090bebc6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b5406e3ad01c https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/net/http/request_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2014-02-20 06:11:05 UTC) #1

minux1

LGTM. I meant to track down the multipartXXX garbage files accumulated in the builder TMPDIR ...

11 years, 4 months ago (2014-02-20 06:20:38 UTC) #2

brainman

11 years, 4 months ago (2014-02-20 06:24:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=41ee82e5a166 ***

net/http: remove tmp file created in TestMultipartReaderOrder

LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/66470043

Expand All Messages | Collapse All Messages