testing: make mgo work if admin password set

testing: make mgo work if admin password set

This means that tests can be much freer about
using authentication.

https://code.launchpad.net/~rogpeppe/juju-core/114-testing-logged-in-session/+merge/128718

(do not edit description out of merge proposal)

[rog, 2012-10-09 14:00:05]

Please take a look.

[rog, 2012-10-09 15:22:29]

Please take a look.

[rog, 2012-10-09 15:33:39]

Please take a look.

[TheMue, 2012-10-09 16:03:02]

Only one little comment, but mostly LGTM.

https://codereview.appspot.com/6643049/diff/3005/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6643049/diff/3005/testing/mgo.go#newcode26
testing/mgo.go:26: mgoDbDir string
Here mgoDb as prefix, for the server instead only mgo. Should be similar.

[rog, 2012-10-09 16:42:30]

Please take a look.

https://codereview.appspot.com/6643049/diff/3005/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6643049/diff/3005/testing/mgo.go#newcode26
testing/mgo.go:26: mgoDbDir string
On 2012/10/09 16:03:02, TheMue wrote:
> Here mgoDb as prefix, for the server instead only mgo. Should be similar.

good point. Done.

[niemeyer, 2012-10-09 22:20:49]

Nice, LGTM

https://codereview.appspot.com/6643049/diff/11002/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6643049/diff/11002/state/state_test.go#newcode987
state/state_test.go:987: // Remove the admin password so that the test harness
can reset.
What can it reset?

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go#newcode112
testing/mgo.go:112: if isUnauthorized(err) {
Nice idea.

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go#newcode113
testing/mgo.go:113: // If we've got an unauthorized access error, so we're
s/so//

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go#newcode120
testing/mgo.go:120: }
I believe we can return here. You've just destroyed it all.

[rog, 2012-10-10 12:46:27]

*** Submitted:

testing: make mgo work if admin password set

This means that tests can be much freer about
using authentication.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6643049

https://codereview.appspot.com/6643049/diff/11002/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6643049/diff/11002/state/state_test.go#newcode987
state/state_test.go:987: // Remove the admin password so that the test harness
can reset.
On 2012/10/09 22:20:49, niemeyer wrote:
> What can it reset?

Done.

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go#newcode113
testing/mgo.go:113: // If we've got an unauthorized access error, so we're
On 2012/10/09 22:20:49, niemeyer wrote:
> s/so//

Done.

https://codereview.appspot.com/6643049/diff/11002/testing/mgo.go#newcode120
testing/mgo.go:120: }
On 2012/10/09 22:20:49, niemeyer wrote:
> I believe we can return here. You've just destroyed it all.

excellent point! done.