Issue 6642046: state: rename ConfigNode as Settings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6642046: state: rename ConfigNode as Settings

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+128574, fwereade

Visibility:
Public.

Description

state: rename ConfigNode as Settings https://code.launchpad.net/~niemeyer/juju-core/confignode-to-settings/+merge/128574 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: rename ConfigNode as Settings #

Patch Set 3 : state: rename ConfigNode as Settings #

Patch Set 4 : state: rename ConfigNode as Settings #

Patch Set 5 : state: rename ConfigNode as Settings #

Patch Set 6 : state: rename ConfigNode as Settings #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -80 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/open_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/relation.go	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	state/relation_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/service.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/settings.go	View	1	8 chunks	+20 lines, -20 lines	0 comments	Download
M	state/settings_test.go	View	1	14 chunks	+32 lines, -32 lines	0 comments	Download
M	state/state.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	state/unit.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/watcher.go	View	1 2	6 chunks	+11 lines, -11 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/jujuc/context.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fwereade

LGTM. Just wish we could come up with a better var name than "node" :).

11 years, 7 months ago (2012-10-08 22:21:35 UTC) #3

niemeyer

On 2012/10/08 22:21:35, fwereade wrote: > LGTM. Just wish we could come up with a ...

11 years, 7 months ago (2012-10-09 13:20:01 UTC) #4

niemeyer

11 years, 7 months ago (2012-10-09 14:38:53 UTC) #5

*** Submitted:

state: rename ConfigNode as Settings

R=fwereade
CC=
https://codereview.appspot.com/6642046

Expand All Messages | Collapse All Messages