Issue 6641046: state: explicit Settings creation and updating

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6641046: state: explicit Settings creation and updating

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+128621, fwereade

Visibility:
Public.

Description

state: explicit Settings creation and updating This turns Settings into explicitly managed resources rather than first-update-creates. Reading or updating non-existing will fail, creating existing will also fail. https://code.launchpad.net/~niemeyer/juju-core/explicit-settings/+merge/128621 Requires: https://code.launchpad.net/~niemeyer/juju-core/unit-has-no-config/+merge/128616 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: explicit Settings creation and updating #

Total comments: 1

Patch Set 3 : state: explicit Settings creation and updating #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -160 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/open.go	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	state/relation.go	View	1 2	1 chunk	+11 lines, -6 lines	0 comments	Download
M	state/relation_test.go	View	1 2	7 chunks	+19 lines, -12 lines	0 comments	Download
M	state/service.go	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	state/settings.go	View	1 2	4 chunks	+47 lines, -31 lines	0 comments	Download
M	state/settings_test.go	View	1 2	18 chunks	+46 lines, -43 lines	0 comments	Download
M	state/state.go	View	1 2	4 chunks	+19 lines, -4 lines	0 comments	Download
M	state/state_test.go	View		5 chunks	+43 lines, -22 lines	0 comments	Download
M	state/watcher.go	View	1 2	2 chunks	+9 lines, -4 lines	0 comments	Download
M	worker/uniter/jujuc/context_test.go	View	1 2	2 chunks	+40 lines, -32 lines	0 comments	Download
M	worker/uniter/jujuc/relation-get_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

LGTM. Cleaner than I had feared it might become... https://codereview.appspot.com/6641046/diff/15/state/settings.go File state/settings.go (right): https://codereview.appspot.com/6641046/diff/15/state/settings.go#newcode240 state/settings.go:240: ...

11 years, 7 months ago (2012-10-09 07:32:05 UTC) #3

niemeyer

11 years, 7 months ago (2012-10-09 16:47:29 UTC) #4

*** Submitted:

state: explicit Settings creation and updating

This turns Settings into explicitly managed resources rather
than first-update-creates. Reading or updating non-existing
will fail, creating existing will also fail.

R=fwereade
CC=
https://codereview.appspot.com/6641046

Expand All Messages | Collapse All Messages