Issue 6639043: cmd/jujud: make bootstrap-state use password

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6639043: cmd/jujud: make bootstrap-state use password

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+128549

Visibility:
Public.

Description

cmd/jujud: make bootstrap-state use password It only does this when the password is set for now, so that we can implement this without breaking things. https://code.launchpad.net/~rogpeppe/juju-core/111-jujud-bootstrap-set-initialpassword/+merge/128549 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: make bootstrap-state use password #

Patch Set 3 : cmd/jujud: make bootstrap-state use password #

Total comments: 4

Patch Set 4 : cmd/jujud: make bootstrap-state use password #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -19 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View	1 2 3	3 chunks	+79 lines, -18 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6639043/diff/4001/cmd/jujud/bootstrap_test.go File cmd/jujud/bootstrap_test.go (right): https://codereview.appspot.com/6639043/diff/4001/cmd/jujud/bootstrap_test.go#newcode116 cmd/jujud/bootstrap_test.go:116: defer func() { I believe this should be ...

11 years, 6 months ago (2012-10-09 12:11:05 UTC) #2

rog

11 years, 6 months ago (2012-10-09 12:39:13 UTC) #3

*** Submitted:

cmd/jujud: make bootstrap-state use password

It only does this when the password is set for now,
so that we can implement this without breaking
things.

R=niemeyer
CC=
https://codereview.appspot.com/6639043

https://codereview.appspot.com/6639043/diff/4001/cmd/jujud/bootstrap_test.go
File cmd/jujud/bootstrap_test.go (right):

https://codereview.appspot.com/6639043/diff/4001/cmd/jujud/bootstrap_test.go#...
cmd/jujud/bootstrap_test.go:116: defer func() {
On 2012/10/09 12:11:05, niemeyer wrote:
> I believe this should be right after SetAdminPassword was known to work above,
> and it should use s.State.

Done.

https://codereview.appspot.com/6639043/diff/4001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/6639043/diff/4001/environs/ec2/ec2.go#newcode348
environs/ec2/ec2.go:348: log.Debugf("ec2 user data: %s", userData)
On 2012/10/09 12:11:05, niemeyer wrote:
> %q?

Done.

Expand All Messages | Collapse All Messages