Issue 6635062: state: add MachineEntityName and UnitEntityName

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6635062: state: add MachineEntityName and UnitEntityName

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+128930

Visibility:
Public.

Description

state: add MachineEntityName and UnitEntityName When we're connecting to the state for a given entity, we have the unit name or machine id, but we can't make a Unit or Machine to get its entity name. Rather than scatter knowledge about entity name construction through the code, these functions centralise it. https://code.launchpad.net/~rogpeppe/juju-core/116-state-entityname-funcs/+merge/128930 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add MachineEntityName and UnitEntityName #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/dummy/environs.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/testing/conn.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/machine.go	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	state/machine_test.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	state/unit_test.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

11 years, 6 months ago (2012-10-10 14:06:48 UTC) #3

*** Submitted:

state: add MachineEntityName and UnitEntityName

When we're connecting to the state for a given
entity, we have the unit name or machine id, but
we can't make a Unit or Machine to get its entity name.

Rather than scatter knowledge about entity
name construction through the code, these
functions centralise it.

R=niemeyer
CC=
https://codereview.appspot.com/6635062

Expand All Messages | Collapse All Messages