Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(739)

Issue 6634047: jujuc: tests no longer depend on state

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by fwereade
Modified:
11 years, 7 months ago
Reviewers:
mp+128706
Visibility:
Public.

Description

jujuc: tests no longer depend on state https://code.launchpad.net/~fwereade/juju-core/jujuc-without-state/+merge/128706 Requires: https://code.launchpad.net/~fwereade/juju-core/jujuc-extract-hook-context/+merge/128641 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : jujuc: tests no longer depend on state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -234 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/jujuc/config-get_test.go View 1 chunk +1 line, -13 lines 0 comments Download
M worker/uniter/jujuc/juju-log_test.go View 5 chunks +4 lines, -13 lines 0 comments Download
M worker/uniter/jujuc/ports_test.go View 2 chunks +10 lines, -12 lines 0 comments Download
M worker/uniter/jujuc/relation-get_test.go View 1 3 chunks +9 lines, -27 lines 0 comments Download
M worker/uniter/jujuc/relation-ids_test.go View 3 chunks +7 lines, -47 lines 0 comments Download
M worker/uniter/jujuc/relation-list_test.go View 4 chunks +7 lines, -12 lines 0 comments Download
M worker/uniter/jujuc/relation-set_test.go View 4 chunks +9 lines, -39 lines 0 comments Download
M worker/uniter/jujuc/server_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/jujuc/unit-get_test.go View 1 chunk +1 line, -9 lines 0 comments Download
M worker/uniter/jujuc/util_test.go View 1 3 chunks +160 lines, -61 lines 0 comments Download

Messages

Total messages: 3
fwereade
Please take a look.
11 years, 7 months ago (2012-10-09 13:23:17 UTC) #1
niemeyer
LGTM
11 years, 7 months ago (2012-10-09 20:17:02 UTC) #2
fwereade
11 years, 7 months ago (2012-10-09 21:40:14 UTC) #3
*** Submitted:

jujuc: tests no longer depend on state

R=niemeyer
CC=
https://codereview.appspot.com/6634047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b