Issue 6632062: uniter: rework config-changed handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6632062: uniter: rework config-changed handling

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by fwereade

Modified:
11 years, 6 months ago

Reviewers:
mp+129066

Visibility:
Public.

Description

uniter: rework config-changed handling Specifically, drop the automatic CC on entering ModeAbide; fulfil guarantees by introducing ModeConfigChanged, invoked in ModeContinue after appropriate precursor hooks and in ModeAbide when no CC has yet been run by the Uniter. https://code.launchpad.net/~fwereade/juju-core/uniter-rework-config-changed/+merge/129066 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : uniter: rework config-changed handling #

Total comments: 2

Patch Set 3 : uniter: rework config-changed handling #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -81 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/filter.go	View	1 2	9 chunks	+30 lines, -34 lines	0 comments	Download
M	worker/uniter/filter_test.go	View	1	2 chunks	+21 lines, -10 lines	0 comments	Download
M	worker/uniter/modes.go	View	1	4 chunks	+21 lines, -22 lines	0 comments	Download
M	worker/uniter/state.go	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	worker/uniter/state_test.go	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	worker/uniter/uniter.go	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	worker/uniter/uniter_test.go	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

This is great. LGTM https://codereview.appspot.com/6632062/diff/3001/worker/uniter/filter.go File worker/uniter/filter.go (right): https://codereview.appspot.com/6632062/diff/3001/worker/uniter/filter.go#newcode231 worker/uniter/filter.go:231: log.Debugf("filter: reset config event") s/reset/discarded/

11 years, 6 months ago (2012-10-11 17:52:15 UTC) #3

fwereade

11 years, 6 months ago (2012-10-11 18:40:53 UTC) #4

*** Submitted:

uniter: rework config-changed handling

Specifically, drop the automatic CC on entering ModeAbide; fulfil guarantees
by introducing ModeConfigChanged, invoked in ModeContinue after appropriate
precursor hooks and in ModeAbide when no CC has yet been run by the Uniter.

R=niemeyer
CC=
https://codereview.appspot.com/6632062

https://codereview.appspot.com/6632062/diff/3001/worker/uniter/filter.go
File worker/uniter/filter.go (right):

https://codereview.appspot.com/6632062/diff/3001/worker/uniter/filter.go#newc...
worker/uniter/filter.go:231: log.Debugf("filter: reset config event")
On 2012/10/11 17:52:15, niemeyer wrote:
> s/reset/discarded/

Done.

Expand All Messages | Collapse All Messages