Issue 6632061: container: set password for unit when deploying

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6632061: container: set password for unit when deploying

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+129000

Visibility:
Public.

Description

container: set password for unit when deploying https://code.launchpad.net/~rogpeppe/juju-core/118-container-use-initial-password/+merge/129000 (do not edit description out of merge proposal)

Patch Set 2 : container: set password for unit when deploying #

Total comments: 2

Patch Set 3 : container: set password for unit when deploying #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -4 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/container.go	View	1 2	3 chunks	+16 lines, -2 lines	0 comments	Download
M	container/container_test.go	View		3 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6632061/diff/2001/container/container.go File container/container.go (right): https://codereview.appspot.com/6632061/diff/2001/container/container.go#newcode100 container/container.go:100: return fmt.Errorf("cannot set password for new machine: %v", ...

11 years, 6 months ago (2012-10-10 17:34:12 UTC) #2

rog

11 years, 6 months ago (2012-10-10 17:38:31 UTC) #3

*** Submitted:

container: set password for unit when deploying

R=niemeyer
CC=
https://codereview.appspot.com/6632061

https://codereview.appspot.com/6632061/diff/2001/container/container.go
File container/container.go (right):

https://codereview.appspot.com/6632061/diff/2001/container/container.go#newco...
container/container.go:100: return fmt.Errorf("cannot set password for new
machine: %v", err)
On 2012/10/10 17:34:12, niemeyer wrote:
> s/new machine/unit/

Done.

Expand All Messages | Collapse All Messages