Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3253)

Issue 6631064: iam: added GetUser method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by fss
Modified:
11 years, 6 months ago
Reviewers:
mp+129026, niemeyer
Visibility:
Public.

Description

iam: added GetUser method https://code.launchpad.net/~franciscosouza/goamz/iam-getuser/+merge/129026 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : iam: added GetUser method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M iam/iam.go View 1 2 chunks +23 lines, -1 line 0 comments Download
M iam/iam_test.go View 1 chunk +17 lines, -0 lines 0 comments Download
M iam/responses_test.go View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5
fss
Please take a look.
11 years, 6 months ago (2012-10-10 19:17:05 UTC) #1
niemeyer
Just one trivial: https://codereview.appspot.com/6631064/diff/1/iam/iam.go File iam/iam.go (right): https://codereview.appspot.com/6631064/diff/1/iam/iam.go#newcode111 iam/iam.go:111: // GetUser gets a new user ...
11 years, 6 months ago (2012-10-10 19:19:56 UTC) #2
fss
Please take a look. https://codereview.appspot.com/6631064/diff/1/iam/iam.go File iam/iam.go (right): https://codereview.appspot.com/6631064/diff/1/iam/iam.go#newcode111 iam/iam.go:111: // GetUser gets a new ...
11 years, 6 months ago (2012-10-10 19:21:53 UTC) #3
niemeyer
*** Submitted: iam: added GetUser method R=niemeyer CC= https://codereview.appspot.com/6631064
11 years, 6 months ago (2012-10-10 19:27:34 UTC) #4
niemeyer
11 years, 6 months ago (2012-10-10 19:29:18 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b