Issue 66310043: environs/manual: use file:// if tools on machine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66310043: environs/manual: use file:// if tools on machine

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by axw

Modified:
10 years, 2 months ago

Reviewers:
mp+207342, wallyworld

Visibility:
Public.

Description

environs/manual: use file:// if tools on machine We previously set the tools URL to file://, assuming they would always be available on the target machine by uploading them. This is not necessarily the case, as tools may now be located on streams.canonical.com. The bug is fixed by first checking that the tools URL originates in the environment storage, and if so sets the URL to file://... Fixes lp:1282235 https://code.launchpad.net/~axwalk/juju-core/lp1282235-manual-bootstrap-tools-source/+merge/207342 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/manual: use file:// if tools on machine #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -17 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/manual/bootstrap.go	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	environs/manual/bootstrap_test.go	View	1	4 chunks	+32 lines, -13 lines	0 comments	Download
M	environs/manual/provisioner.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages