Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(302)

Issue 66260043: code review 66260043: ogle/gosym: new package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by nigeltao
Modified:
7 years, 9 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/gosym: new package. This is a fork of $GOROOT/src/pkg/debug/gosym. I intend to add experimental API, but am not yet ready to make the standard library's backwards compatibility commitment. This CL is a straight copy from Go tip with no changes. Future CLs will add code. $ cd $GOROOT/src/pkg/debug/gosym $ hg identify da7a98d40bd5+ tip

Patch Set 1 #

Patch Set 2 : diff -r 11112a8e1795 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 11112a8e1795 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 11112a8e1795 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1470 lines, -0 lines) Patch
A gosym/pclinetest.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
A gosym/pclinetest.asm View 1 1 chunk +58 lines, -0 lines 0 comments Download
A gosym/pclntab.go View 1 1 chunk +426 lines, -0 lines 0 comments Download
A gosym/pclntab_test.go View 1 1 chunk +274 lines, -0 lines 0 comments Download
A gosym/symtab.go View 1 1 chunk +703 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 9 months ago (2014-02-20 01:03:59 UTC) #1
r
LGTM
7 years, 9 months ago (2014-02-20 01:22:35 UTC) #2
nigeltao
7 years, 9 months ago (2014-02-20 01:39:22 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=ac1c51d47094 ***

ogle/gosym: new package.

This is a fork of $GOROOT/src/pkg/debug/gosym. I intend to add
experimental API, but am not yet ready to make the standard library's
backwards compatibility commitment.

This CL is a straight copy from Go tip with no changes. Future CLs will
add code.
$ cd $GOROOT/src/pkg/debug/gosym
$ hg identify
da7a98d40bd5+ tip

LGTM=r
R=r
https://codereview.appspot.com/66260043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b