Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(583)

Issue 6625058: code review 6625058: image/jpeg: move the huffman bit decoder state higher u... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by nigeltao
Modified:
9 years, 1 month ago
Reviewers:
CC:
r, dfc, golang-dev
Visibility:
Public.

Description

image/jpeg: move the huffman bit decoder state higher up in the decoder struct, inside the unmappedzero limit, to eliminate some TESTB instructions in the inner decoding loop. benchmark old ns/op new ns/op delta BenchmarkDecode 2943204 2746360 -6.69%

Patch Set 1 #

Patch Set 2 : diff -r 187194a52289 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 187194a52289 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 308dea0e3d68 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/image/jpeg/reader.go View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 1 month ago (2012-10-07 03:31:30 UTC) #1
dfc
On 2012/10/07 03:31:30, nigeltao wrote: > Hello mailto:r@golang.org (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
9 years, 1 month ago (2012-10-07 04:14:23 UTC) #2
r
LGTM
9 years, 1 month ago (2012-10-07 05:22:22 UTC) #3
nigeltao
9 years, 1 month ago (2012-10-07 08:32:35 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=7b037816cd5c ***

image/jpeg: move the huffman bit decoder state higher up in the
decoder struct, inside the unmappedzero limit, to eliminate some
TESTB instructions in the inner decoding loop.

benchmark          old ns/op    new ns/op    delta
BenchmarkDecode      2943204      2746360   -6.69%

R=r, dave
CC=golang-dev
http://codereview.appspot.com/6625058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b