Code review - Issue 6625058: code review 6625058: image/jpeg: move the huffman bit decoder state higher u...https://codereview.appspot.com/2012-10-07T08:32:35+00:00rietveld
Message from unknown
2012-10-07T03:31:00+00:00nigeltaourn:md5:9b831f527a141c262cff038b247991cf
Message from unknown
2012-10-07T03:31:05+00:00nigeltaourn:md5:6c057072ee937b7576dc05ba49d4671e
Message from unknown
2012-10-07T03:31:25+00:00nigeltaourn:md5:6f01ed535c20e95ae225f9859ab9ea94
Message from nigeltao@golang.org
2012-10-07T03:31:30+00:00nigeltaourn:md5:0cbd3b8546a30b0a66ee3d8fc6efbccd
Hello r@golang.org (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from dave@cheney.net
2012-10-07T04:14:23+00:00dfcurn:md5:034d4f975b97cb3a5a0c5fa0bffa55ed
On 2012/10/07 03:31:30, nigeltao wrote:
> Hello mailto:r@golang.org (cc: mailto:golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
LGTM. Very interesting catch.
Message from r@golang.org
2012-10-07T05:22:22+00:00rurn:md5:5ffd9b08f9b36904edb564b9cd56143d
LGTM
Message from unknown
2012-10-07T08:32:20+00:00nigeltaourn:md5:62ed870502f48f6efcfdfecf78bb2832
Message from nigeltao@golang.org
2012-10-07T08:32:35+00:00nigeltaourn:md5:eae17634a4a4976c4ea8f3357bc3a4c8
*** Submitted as http://code.google.com/p/go/source/detail?r=7b037816cd5c ***
image/jpeg: move the huffman bit decoder state higher up in the
decoder struct, inside the unmappedzero limit, to eliminate some
TESTB instructions in the inner decoding loop.
benchmark old ns/op new ns/op delta
BenchmarkDecode 2943204 2746360 -6.69%
R=r, dave
CC=golang-dev
http://codereview.appspot.com/6625058