cmd/jujud: make bootstrap-state accept password

cmd/jujud: make bootstrap-state accept password

This makes bootstrap-state accept all the same flags
as the agents (including --data-dir which it doesn't use;
but it seems to me that it may well use it in the future).

https://code.launchpad.net/~rogpeppe/juju-core/107-jujud-bootstrap-initial-password/+merge/128210

(do not edit description out of merge proposal)

[rog, 2012-10-05 10:45:24]

Please take a look.

[rog, 2012-10-05 10:47:33]

Please take a look.

[fwereade, 2012-10-05 11:29:51]

I don't really think it's right to advertise and accept flags that don't do
anything, so I'd be much happier if the common stuff didn't include data-dir at
the moment. Personally, -0 on this; would almost certainly become +1 if
bootstrap-state weren't polluted :).

[niemeyer, 2012-10-05 15:33:41]

https://codereview.appspot.com/6623047/diff/6001/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/6623047/diff/6001/cmd/jujud/bootstrap.go#newco...
cmd/jujud/bootstrap.go:26: c.Conf.addFlags(f)
Adding --data-dir on bootstrap-state doesn't worry me too much, but I agree with
William that the precedent is dangerous. We may soon start seeing other
completely unrelated options being added.

It's easy to avoid both the duplication and the unwanted options:

c.Conf.addFlags(f, optStateInfo | optInitialPassword)

In all other cases for now:

c.Conf.addFlags(f, optAll)

[rog, 2012-10-05 15:57:01]

Please take a look.

[rog, 2012-10-05 15:57:24]

https://codereview.appspot.com/6623047/diff/6001/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/6623047/diff/6001/cmd/jujud/bootstrap.go#newco...
cmd/jujud/bootstrap.go:26: c.Conf.addFlags(f)
On 2012/10/05 15:33:42, niemeyer wrote:
> Adding --data-dir on bootstrap-state doesn't worry me too much, but I agree
with
> William that the precedent is dangerous. We may soon start seeing other
> completely unrelated options being added.
> 
> It's easy to avoid both the duplication and the unwanted options:
> 
> c.Conf.addFlags(f, optStateInfo | optInitialPassword)
> 
> In all other cases for now:
> 
> c.Conf.addFlags(f, optAll)

Done.

[niemeyer, 2012-10-05 17:21:02]

LGTM

[rog, 2012-10-05 17:37:44]

*** Submitted:

cmd/jujud: make bootstrap-state accept password

This makes bootstrap-state accept all the same flags
as the agents (including --data-dir which it doesn't use;
but it seems to me that it may well use it in the future).

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6623047

[rog, 2012-10-08 17:05:51]

Please take a look.

[niemeyer, 2012-10-08 20:42:58]

On 2012/10/08 17:05:51, rog wrote:
> Please take a look.

Roger, this branch was submitted 3 days ago, and somehow it was just
re-proposed. Are you trying to push something else for review?

[niemeyer, 2012-10-08 20:44:24]

Yeah, looks like the merged state was corrupted.